> > > Why did you move the declarations of jtag_tap_{init,free} to the bottom
> > > of jtag.h?
> >
> > Lack of reason to put them anywhere else in that file. They
> > clearly didn't belong as externs in that ".c" file, though.
>
> Better than exposing them in a public API. I had thought about adding
> jtag/core.h to export internal JTAG module symbols like this; I think
> there may be other bits of the jtag.h file that could be moved in there.
There *is* no "public API" today, so that's a non-reason.
Having any "*.c" file have a declaration for something in
another file -- instead of having it in a "*.h" file -- is
worse than having not-quite-pure-yet headers. It's trivial
for the declarations to get of sync.
> If there are reports from others that these patches solves problems, we
> should try to push some flavor of them into 0.2.0. Still, I would like
> to see the functionality from the first two patches layered properly.
Still hunting for suggestions on how "proper" layering would
work though...
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development
