You are looking at the wrong code. The bug was probably introduced in
command.c. Right now I have no time whatsoever to work on this and
track down what was changed there.

This is copy&paste from a telnet session I just tried on an r517 build
that I have lying around here:

Open On-Chip Debugger
> arm11 memwrite burst 0
Disabled memory write burst mode.
> arm11 memwrite burst 1
Enabled memory write burst mode.
>

RC_TOP marks a command that has further subcommands, not a command
that starts at the top level. If the BOOL_WRAPPER handles the argument
on a fixed position then this indicates (this was a year ago, so I
don't remember and can only guess) that at the time when this was
programmed the sub-commands were passed to the function without the
top commands.


Michael



On Mon, Jun 15, 2009 at 6:02 AM, David Brownell<[email protected]> wrote:
> On Sunday 14 June 2009, Michael Bruck wrote:
>> When I programmed this it used to work under arm11. If it does not
>> work now, then someone broke the command code. This should be fixed
>> rather than messing up the command structure.
>
> Then you seem to be the best candidate for that ...
>
> The arm11.c file went (IMO) a bit overboard with macros, but if
> I mentally un-wrap them the issues seem to be that:
>
>  (a) arm11_register_commands() uses RC_TOP to define a toplevel
>      command ... seems to have done so since 27-feb-2008 though,
>      the original checkin for "memwrite";
>
>  (b) the BOOL_WRAPPER thing expects enable/disable as the SECOND
>      param, not the third as it would be with the "arm11".
>
> I'm not sure I see how what got checked in ever worked with the
> prefix though.
>
> - Dave
>
>
>
>> Michael
>>
>> On Sun, Jun 14, 2009 at 9:00 PM, David Brownell<[email protected]> wrote:
>> > Fix glitches in ARM11 command doc:  the commands
>> > are "memwrite ..." not "arm11 memwrite ...".  Both
>> > the texi and the source code (!) got that wrong.
>> > Re-alphabetize.
>> > ---
>> >  doc/openocd.texi   |   24 ++++++++++++------------
>> >  src/target/arm11.c |    2 +-
>> >  2 files changed, 13 insertions(+), 13 deletions(-)
>> >
>> >        NOTE: making "arm11 memwrite ..." work would
>> >        be cleaner, but more work.  Plus it would change
>> >        current behavior.
>> >
>>
>
>
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to