On Fri, Nov 27, 2009 at 7:13 PM, David Brownell <[email protected]> wrote:
> On Friday 27 November 2009, Dean Glazeski wrote: > > On Fri, Nov 27, 2009 at 2:12 AM, David Brownell <[email protected]> > wrote: > > > > > On Monday 23 November 2009, Dean Glazeski wrote: > > > > point. The new play area is http://repo.or.cz/w/openocd/dnglaze.git > . > > > I've > > > > > > I merged a few of these. The page command refactoring: > > > > > > + if (oob && NAND_CMD_READ0 && nand->page_size <= 512) { > > > + cmd = NAND_CMD_READOOB; > > > + } > > > > > > looks buggy for "&& NAND_CMD_READ0 && " ... and I'd drop the > > > needless brackets. > > > > > > You make a good point and I did think of that when I originally wrote > this. > > What -- that "&& constant ..." is a constant? I think you misread > that ... > Oh, now I see. Nice catch. Don't I feel silly :). I don't have a NAND with a page size that fits that comparison so I never saw it. I'll fix that up. // Dean Glazeski
_______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
