Øyvind Harboe wrote:
On Wed, Mar 24, 2010 at 4:03 PM, Laurent Gauch
<[email protected]> wrote:
Target scripts without a adapter_khz should be fixed to have one,
otherwise the khz is undefined.
So the adapter_khz do not have the good name ;-( as I just wrote to a
previous message.
Or the mechanism around the JTAG frequency is wrong.

Naming aside(I'm a bit naming & whitespace blind), to me it seems
pretty straightforward that a target script tells the adapter the
maximum clock frequency.

# This target fails above 2000khz, so we set the maximum
# adapter frequency to 2000khz....
adapter_khz 2000

I'm not sure how much more clear it can become...

something much more clear will be :
'target_jtag_max_tck_frequency_khz'
instead
'adapter_khz'

then we could have
'target_swd_max_tck_frequency_khz'

...

At long term, the adapter_khz will only make mistake !
I don't like to have to talk about 'adapter' on the target environment / layer. Do you ?

jtag_khz was a lot better than the adapter_khz we have now. But it should be still better with 'target_jtag_max_tck_frequency_khz'

'target_jtag_max_tck_frequency_khz' can be used in both board and target script and it is more clear for end-user.

I vote for 'target_jtag_max_tck_frequency_khz' . Do you ?

Laurent Gauch
 http://www.amontec.com






_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to