Why hasn't anybody complained yet that "flash write_image erase" will fail for elf images that are not aligned to sectors???
Unlocking is automatically aligned to sectors in this case... I'll be committing this soonish if I don't hear any protests or insights... -- Meet Zylin at ESC 2010 San Jose April 26 - 30. 2010 http://www.zylin.com/events_esc2010.html Øyvind Harboe US toll free 1-866-980-3434 / International +47 51 63 25 00 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer
From 78248f1df67d1b4feefd8ac4e459acd7599d6af2 Mon Sep 17 00:00:00 2001 From: =?utf-8?q?=C3=98yvind=20Harboe?= <[email protected]> Date: Thu, 29 Apr 2010 03:49:32 +0200 Subject: [PATCH] flash: write_image will now pad erase to nearest sector MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit this is done for unlocking and it is a simple omission that it wasn't done for sectors. The unnerving thing is that nobody has complained about this until now.... Signed-off-by: Øyvind Harboe <[email protected]> --- src/flash/nor/core.c | 10 ++-------- 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/flash/nor/core.c b/src/flash/nor/core.c index b8dda96..1ff4193 100644 --- a/src/flash/nor/core.c +++ b/src/flash/nor/core.c @@ -1,6 +1,6 @@ /*************************************************************************** * Copyright (C) 2005 by Dominic Rath <[email protected]> * - * Copyright (C) 2007,2008 Øyvind Harboe <[email protected]> * + * Copyright (C) 2007-2010 Øyvind Harboe <[email protected]> * * Copyright (C) 2008 by Spencer Oliver <[email protected]> * * Copyright (C) 2009 Zachary T Welch <[email protected]> * * * @@ -519,12 +519,6 @@ int flash_write_unlock(struct target *target, struct image *image, struct flash_bank *c; int *padding; - /* REVISIT do_pad should perhaps just be another parameter. - * GDB wouldn't ever need it, since it erases separately. - * But "flash write_image" commands might want that option. - */ - bool do_pad = false; - section = 0; section_offset = 0; @@ -694,7 +688,7 @@ int flash_write_unlock(struct target *target, struct image *image, { /* calculate and erase sectors */ retval = flash_erase_address_range(target, - do_pad, run_address, run_size); + true, run_address, run_size); } } -- 1.6.3.3
_______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
