Ouch. Like so?
-- Øyvind Harboe Can Zylin Consulting help on your project? US toll free 1-866-980-3434 / International +47 51 87 40 27 http://www.zylin.com/zy1000.html ARM7 ARM9 ARM11 XScale Cortex JTAG debugger and flash programmer
From a0b83e82f7fa1833f7ac137d052335c55d1a4223 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C3=98yvind=20Harboe?= <[email protected]> Date: Fri, 1 Apr 2011 12:32:41 +0200 Subject: [PATCH] mips: fix gaffe in previous commit MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit accidentally invoked return jtag_execute_queue() in the middle of a fn. Hmm.... I would have expected gcc or at least lint to catch this. Signed-off-by: Øyvind Harboe <[email protected]> --- src/target/mips32_pracc.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/target/mips32_pracc.c b/src/target/mips32_pracc.c index 0ee5715..2dc7a8f 100644 --- a/src/target/mips32_pracc.c +++ b/src/target/mips32_pracc.c @@ -194,7 +194,10 @@ static int mips32_pracc_exec_write(struct mips32_pracc_context *ctx, uint32_t ad mips_ejtag_drscan_32(ctx->ejtag_info, &ejtag_ctrl); jtag_add_clocks(5); - return jtag_execute_queue(); + int retval; + retval = jtag_execute_queue(); + if (retval != ERROR_OK) + return retval; if ((address >= MIPS32_PRACC_PARAM_IN) && (address <= MIPS32_PRACC_PARAM_IN + ctx->num_iparam * 4)) -- 1.7.2.3
_______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
