On Mon, 30 May 2011 12:51:56 +0000, Tomek CEDRO wrote:
Hello Sebastien,
Hello Tomek,
On Mon, 30 May 2011 12:51:56 +0000, Tomek CEDRO wrote:
Please stay to your convention and use "open" to open functionality
and "init" to init functionality - this is very good idea and used in
transport layer (select, then init), but there is "select" instead of
"open", so maybe we should change all names to "open"..?
On Thu, 14 Apr 2011 11:07:12, Sebastien Farquet wrote:
At the beginning, I wanted make a modification for any jtag adapter.
I think, the best case if it's correct for all jtag adapter it's to
work like Laurent has said:
The better case for jtag adapter would be to have
.open
.init
.xxx-interface-me-xxx
.deinit
.close
.open and .close the handle of the jtag adapter
.init and deinit the jtag adapter itself.
But the actual openocd only knows the .init and .quit, and we have
to
do with. If we go with .open .init .deinit .close, it will make a
lot
of more work on all the specific jtag driver. -> could be modified
on
a second step ...
But it's a long and hard work.
So I hope make:
On Thu, 14 Apr 2011 13:25:03, Sebastien Farquet wrote:
I work to do that.
But the summary of my current work is:
x = ftd2xx or libftdi
ft2232_init()
ft2232_open_x()
ft2232_init_x()
if error occured
ft2232_close_x()
ft2232_quit()
ft2232_deinit_x()
ft2232_close_x()
I divide functions and create new to have a more clearly code.
On Mon, 18 Apr 2011 14:11:34 +0200, Drasko DRASKOVIC wrote:
2) Split your changes in several smaller patches, well documented.
This augments your chances that at least some of the changes will get
accepted. It is because some of maintainers, or some programmers on
the list will not (lack of time) look deeper in some areas, while
other fall in their expertise and they will give it a quick look. If
you have big change that spreads over few different areas, there is
smaller change that you will find expert that will go over your
patches.
So it's the first part of the patch.
I have divide the existing functions and add the code to identify an
init error when the ft device is opened .
So the ft device is correctly closed and ft2232_buffer is correctly
free.
On Mon, 30 May 2011 12:51:56 +0000, Tomek CEDRO wrote:
Using "init_sub" brings confusion which "init" is it, or maybe
"open"?
I have choose "ft2232_init_sub" because this function is in function
"ft2232_init" and previously it's a part of the function "ft2232_init".
But if you prefere, I can choose: "init2"
Because in the current source, in file: openocd.c, we can see: main2
which is a part of openocd_main
On Mon, 18 Apr 2011 14:11:34 +0200, Drasko DRASKOVIC wrote:
Maintainers take responsibility for what get's into the
repository, and it is some kind of guarantee for all of us that
tomorrow we will meet again high-quality code in OpenOCD project.
Please correct me if im wrong :-)
I hope that answers your questions :-)
Best regards :-)
Tomek
--
Regards,
Sébastien Farquet
http://www.amontec.com/
Amontec JTAGkey-2 : High speed USB JTAG interface
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development
