On Mon, Aug 29, 2011 at 7:35 PM, Øyvind Harboe <[email protected]> wrote: > On Mon, Aug 29, 2011 at 1:07 PM, Jean-Christophe PLAGNIOL-VILLARD > <[email protected]> wrote: >> Hi, >> >> personnally I'd like we use the same coding style as the kernel >> >> in the kernel anre barebox we use checkpatch to check the patch coding >> style > > I don't mind picking the kernel style, if nothing else because we then can get > scripts to check for the style.
The kernel script "scripts/checkpatch.pl" can be used both for a patch and for the whole file (with flag "-f"). This is for sure good. Don't know if can be used on TCL files too. Whatever coding stile or script we use, sooner or later we need to apply it to whole files. Using it only to check patches will mess-up the files by mixing new coding stile in the new parts and legacy style in the rest of file. Changing stile (indentation, spaces here and there, tabs, ...) can be very invasive. In this case adding flag "--word-diff" to "git format-patch" will create patches that are shorter and much more easy to review. Best Regards, Antonio Borneo _______________________________________________ Openocd-development mailing list [email protected] https://lists.berlios.de/mailman/listinfo/openocd-development
