-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Just noticed that musiconhold didn't deactivate a generator that was
already running on a channel and then started it's own.
Since it seems like this is something that might happen, and is
probably happening in other parts of the code I suggest the following
addition to the opbx_generator_activate function:
/* If a generator is already active on the channel, * stop it */
if (pgcd->gen_is_active) {
opbx_log(LOG_WARNING, "Generator was already active on"
"channel %s when starting a new one!\n", chan->name);
opbx_generator_deactivate(chan);
}
This would stop any running generators and print a warning each time a
new one is started on the channel.
So my question is if this is a good thing? Is there ever a legitimate
reason not to stop a running generator when starting a new one?
My limited testing has uncovered no problems so far, but then the
testing was pretty basic.
So should I commit this to trunk, or does anyone have objections to
it?
/B
- --
* GPG-Key: http://evil.gnarf.org/mrbk.pgp
A: Because we read from top to bottom, left to right.
Q: Why should i start my reply below the quoted text?
- -- http://www.i-hate-computers.demon.co.uk/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
iD8DBQFD8youckvkFeO3ANARAoCIAKCGXXLBE9L0RevOvR4gVY6tiWurAQCffwc4
enWnkG4dwkEhZoT1e1w5drU=
=8sZy
-----END PGP SIGNATURE-----
_______________________________________________
Openpbx-dev mailing list
[email protected]
http://lists.openpbx.org/mailman/listinfo/openpbx-dev
