-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On Thu, 16 Feb 2006, Armin Schindler wrote: <snipp> >> So my question is if this is a good thing? Is there ever a legitimate >> reason not to stop a running generator when starting a new one? >> My limited testing has uncovered no problems so far, but then the >> testing was pretty basic. >> So should I commit this to trunk, or does anyone have objections to >> it? > I don't think it is necessary to do that at all. The generator thread will > deactivate any running generator by itself when it receives a new request. > Have a look at the static void *opbx_generator_thread(void *data) function: > ... <snipp> > ... > If this doesn't work as expected, then it should be fixed here instead of > another deactivation call somewhere else in the code.
It doesn't seem to work, since it broke musiconhold until I added a call to deactivate the generator to musiconhold. It seems that the opbx_generator_activate function starts a new thread not just sends a new request, but I haven't really looked into it yet. /B - -- * GPG-Key: http://evil.gnarf.org/mrbk.pgp A: Because we read from top to bottom, left to right. Q: Why should i start my reply below the quoted text? - -- http://www.i-hate-computers.demon.co.uk/ -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFD9HpnckvkFeO3ANARAkGlAKDJD9qNi53eL6dyhDPtt0Bem9W+1wCgtOC5 21MZBkBy6tRUzl4dEB0AbpQ= =ywgo -----END PGP SIGNATURE----- _______________________________________________ Openpbx-dev mailing list [email protected] http://lists.openpbx.org/mailman/listinfo/openpbx-dev
