OpenPKG CVS Repository
http://cvs.openpkg.org/
____________________________________________________________________________
Server: cvs.openpkg.org Name: Ralf S. Engelschall
Root: /v/openpkg/cvs Email: [EMAIL PROTECTED]
Module: openpkg-src Date: 13-Aug-2005 14:24:48
Branch: HEAD Handle: 2005081313244800
Modified files:
openpkg-src/abiword abiword.patch abiword.spec
Log:
In my never ending crusade for a correct UUID generation world, fix one
more incorrect piece of code (hell, isn't it nice what cut & paste in
the Internet world can result in?)
To understand it:
Fix generation of random multicast MAC address.
In case no real/physical IEEE 802 address is available, both the expired
"draft-leach-uuids-guids-01" (section "4. Node IDs when no IEEE 802
network card is available") and RFC 2518 (section "6.4.1 Node Field
Generation Without the IEEE 802 Address") recommend (quoted from RFC
2518):
"The ideal solution is to obtain a 47 bit cryptographic quality random
number, and use it as the low 47 bits of the node ID, with the _most_
significant bit of the first octet of the node ID set to 1. This bit
is the unicast/multicast bit, which will never be set in IEEE 802
addresses obtained from network cards; hence, there can never be a
conflict between UUIDs generated by machines with and without network
cards."
Unfortunately, this incorrectly explains how to implement this and
this UUID generator code inherited this generation bug from
the broken reference code in the standards draft. They should instead
specify the "_least_ significant bit of the first octet of the node ID"
as the multicast bit in a memory and hexadecimal string representation
of a 48-bit IEEE 802 MAC address.
This standards bug arised from a false interpretation, as the multicast
bit is actually the _most_ significant bit in IEEE 802.3 (Ethernet)
_transmission order_ of an IEEE 802 MAC address. The standards authors
forgot that the bitwise order of an _octet_ from a MAC address _memory_
and hexadecimal string representation is still always from left (MSB,
bit 7) to right (LSB, bit 0).
Summary:
Revision Changes Path
1.7 +12 -0 openpkg-src/abiword/abiword.patch
1.40 +1 -1 openpkg-src/abiword/abiword.spec
____________________________________________________________________________
patch -p0 <<'@@ .'
Index: openpkg-src/abiword/abiword.patch
============================================================================
$ cvs diff -u -r1.6 -r1.7 abiword.patch
--- openpkg-src/abiword/abiword.patch 13 Jan 2005 14:43:55 -0000 1.6
+++ openpkg-src/abiword/abiword.patch 13 Aug 2005 12:24:48 -0000 1.7
@@ -95,3 +95,15 @@
#ifndef _SSIZE_T_
typedef size_t ssize_t;
#endif
+Index: abi/src/af/util/xp/ut_uuid.cpp
+--- abi/src/af/util/xp/ut_uuid.cpp.orig 2004-08-20 00:10:08 +0200
++++ abi/src/af/util/xp/ut_uuid.cpp 2005-08-13 14:21:55 +0200
+@@ -368,7 +368,7 @@
+ * with IEEE 802 addresses obtained from
+ * network cards
+ */
+- s_node[0] |= 0x80;
++ s_node[0] |= 0x01;
+ }
+ s_bInitDone = bRet;
+ }
@@ .
patch -p0 <<'@@ .'
Index: openpkg-src/abiword/abiword.spec
============================================================================
$ cvs diff -u -r1.39 -r1.40 abiword.spec
--- openpkg-src/abiword/abiword.spec 24 Mar 2005 11:18:22 -0000 1.39
+++ openpkg-src/abiword/abiword.spec 13 Aug 2005 12:24:48 -0000 1.40
@@ -33,7 +33,7 @@
Group: Editor
License: GPL
Version: 2.2.3
-Release: 20050114
+Release: 20050813
# list of sources
Source0:
http://osdn.dl.sourceforge.net/sourceforge/abiword/abiword-%{version}.tar.gz
@@ .
______________________________________________________________________
The OpenPKG Project www.openpkg.org
CVS Repository Commit List [email protected]
