On Wed, Aug 30, 2006, Ralf S. Engelschall wrote: >On Mon, Aug 28, 2006, Bill Campbell wrote: > >> The attached patch to the spamassassin-3.1.4-20060825.src.rpm run >> control file, rc.spamassassin, sets a new configuration variable, >> spamassassin_stop_sleep="5", and moves the sleep from the restart >> to the stop section. >> [...] > >I've taken over this change idea, but we have to keep in mind that this >is a general OpenPKG issue: we have lots of daemons which do the sleep >in %stop and also lots we do it in %restart. This should be aligned in >all packages, but the question is what is generally better: %stop and >%restart. I also tend to %stop myself...
I prefer doing in stop as I often do ``rc package stop start'' to insure that the stop processing is done (which may remove pid files), and the start is then done. A restart won't start a process that isn't running so isn't as general. I think it would be a Good Idea(tm) have the stop time in a %config variable to allow per-site tweaking. I've found several packages that may take a fairly long time to terminate all processes on busy systems (apache comes to mind) and the hard coded sleep time isn't sufficient. I used the variable name packagename_stop_sleep in case there are other sleep times in a run control script that should have their own sleep time variable. Bill -- INTERNET: [EMAIL PROTECTED] Bill Campbell; Celestial Software LLC URL: http://www.celestial.com/ PO Box 820; 6641 E. Mercer Way FAX: (206) 232-9186 Mercer Island, WA 98040-0820; (206) 236-1676 ``The whole aim of practical politics is to keep the populace alarmed (and hence clamorous to be led to safety) by an endless series of hobgoblins.'' -- H.L. Mencken, 1923 ______________________________________________________________________ The OpenPKG Project www.openpkg.org Developer Communication List openpkg-dev@openpkg.org
