On 05/26/2012 07:47 PM, Peter Gavin wrote:
Something's still fishy here.
or1k_compare_op[01] are never assigned anywhere, as you said, but
or1k_output_bf and or1k_output_cmov refer to them. It seems that
there should be segfaults in those functions, too, but there isn't,
which is odd.
I want to look at this a bit more before I apply it.
Yes, or1k_compare_op{0|1} should probably be removed completely.
They seem to be leftovers from cmpxx.
The reason they don't cause problems in or1k_output_bf and or1k_output_cmov
is that they are used as the x and y parameters of the SELECT_CC_MODE
macro.
But x and y are never used in that macro.
I probably should have put a note about this in my initial mail,
the main reason why I didn't remove them completely was that
I didn't want to fiddle too much, and I didn't come up with
what would be reasonable to send SELECT_CC_MODE instead.
Stefan
_______________________________________________
OpenRISC mailing list
[email protected]
http://lists.openrisc.net/listinfo/openrisc
