2012/12/31 Jeremy Bennett <[email protected]>: > On Fri, 2012-12-28 at 23:22 +0100, Franck Jullien wrote: >> This is a version of the target descriptor support using group names >> from the target descriptor file. >> >> In this version, tdesc feature names are predefined in GDB. It defines 32 >> possible features (org.gnu.gdb.or32.group[0..31]) corresponding to the >> openrisc architecture manual definition. >> >> Each register can be put in a group (there is no limit) using the "group" >> attibute of the register description in the XML feature. >> >> Groups are created at runtime. > > Hi Franck, > > Great piece of work. From your earlier email, I prefer the generalized > approach, where you add more structure to the basic XML feature. In this > case to provide SPR groups. > > It would be really good to do two things with this. 1) Run it past the > GDB mailing list, to see if you get any feedback about why this might > not be a good thing. 2) Document it well, so that future users of XML > architecture specifications can learn from OpenRISC. This should be both > in the user guides and in Doxygen comments in the code. > > Best wishes, > > > Jeremy > >> >> Franck Jullien (3): >> or32: set gdbarch num regs to gpr + spr regs >> target-description: add tdesc_find functions >> or32: add target descriptor support >> >> gdb/or32-tdep.c | 227 >> +++++++++++++++++++++++++++++++++++++++++++-- >> gdb/or32-tdep.h | 4 +- >> gdb/target-descriptions.c | 48 ++++++++- >> gdb/target-descriptions.h | 11 ++ >> 4 files changed, 273 insertions(+), 17 deletions(-) >> > > -- > Tel: +44 (1590) 610184 > Cell: +44 (7970) 676050 > SkypeID: jeremybennett > Email: [email protected] > Web: www.embecosm.com > > _______________________________________________ > Openrisc mailing list > [email protected] > http://lists.opencores.org/listinfo/openrisc
Thanks Jeremy for your feedback. I think I'll keep this version of my patches since it introduce less changes in the GDB core. However, I'll post on the GDB mailing list to get some feedback on both solutions. Franck. _______________________________________________ OpenRISC mailing list [email protected] http://lists.openrisc.net/listinfo/openrisc
