On Mon, Apr 14, 2014 at 10:26 PM, Stefan Kristiansson <[email protected]> wrote: > On Mon, Apr 14, 2014 at 3:47 PM, Stefan Wallentowitz > <[email protected]> wrote: >> No, of course it would be nice if you pull it after review. > > I didn't really find anything to complain about, so I've applied the > patches with only a small change to a comment referring to > "OPTIMSOC_I/DCACHE_WAYS". >
After some more in-depth testing, I found one small issue, for which I have already pushed a fix for: https://github.com/openrisc/mor1kx/commit/7db7a341f9886851fb18d6c4a1a0b00de7016f24 As a slightly related note - in retro-perspective, I think it was a mistake to keep all the ways in *one* tag memory. I did that as a way to more efficiently use the block ram in FPGAs, but in the end, I think the trade-offs are to costly. The split-up of the tag memory data when it's read and written that you did in those commits have already made it easier to make a transition for that. Stefan _______________________________________________ OpenRISC mailing list [email protected] http://lists.openrisc.net/listinfo/openrisc
