ACK Thanks -Nagu
-----Original Message----- From: Praveen Malviya Sent: 27 September 2013 11:37 To: [email protected]; Nagendra Kumar Cc: [email protected] Subject: [PATCH 0 of 2] Review Request for amfd: quiesced role honoring SI dependency during node lock in NWAY [#90] Summary: quiesced role honoring SI dependency during node lock in NWAY [#90] Review request for Trac Ticket(s): amf #90 Peer Reviewer(s): Hans F., Nagendra Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es):Default Development branch: <<IF ANY GIVE THE REPO URL>> -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- Please see the commit log below. changeset 2c38d59dc53c784121ac12029b5e3754989f19e6 Author: [email protected] Date: Fri, 27 Sep 2013 11:24:42 +0530 amfd: rename SI dep related function to be used by other red models [#90] In this patch two functions have been renamed and moved from sg_2n_fsm.cc and sgproc.cc to siass.cc. These functions will used by other red models also in the context of SI dependency feature. At present sg_2n_fsm is using these functions, so names have been changed in sg_2n_fsm.cc changeset d1bb7472d7fd3af3d85be157770f168ca9f67834 Author: [email protected] Date: Fri, 27 Sep 2013 11:30:54 +0530 amfd : assign quiesced role honoring SI dep during node lock in NWAY model [#90] During Node lock and SU lock, if SI dependency is configured within SU then quiesced assignment will be given in the reverse order of SI dependecy. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/include/susi.h | 2 + osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 48 +++++---------------------------- osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 43 ++++++++++++++++++++++++++---- osaf/services/saf/amf/amfd/sgproc.cc | 59 +----------------------------------------- osaf/services/saf/amf/amfd/si_dep.cc | 44 ++++++++++++++++++++++++++----- osaf/services/saf/amf/amfd/siass.cc | 90 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 6 files changed, 174 insertions(+), 112 deletions(-) Testing Commands: ----------------- Tested configuration given in the ticket description. Testing, Expected Results: -------------------------- Fist dependents get the quiesced role then sponsors. Conditions of Submission: ------------------------- Ack from Hans or Nagendra. Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 y y x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
