On Tuesday 29 April 2014 10:58 AM, Hans Feldt wrote:
>   osaf/libs/core/mds/include/mds_dt.h |  3 ---
>   osaf/libs/core/mds/mds_dt_tipc.c    |  2 +-
>   2 files changed, 1 insertions(+), 4 deletions(-)
>
>
> Using connection-less TIPC messaging the largest message that can be sent and
> received is 66000 defined by the constant TIPC_MAX_USER_MSG_SIZE defined in
> tipc.h
>
> The patch change the MDS TIPC code to use the TIPC constant instead of 
> defining
> in its own lower limit (for no reason).
>
> No functional change. Just preparation for other changes.
>
> diff --git a/osaf/libs/core/mds/include/mds_dt.h 
> b/osaf/libs/core/mds/include/mds_dt.h
> --- a/osaf/libs/core/mds/include/mds_dt.h
> +++ b/osaf/libs/core/mds/include/mds_dt.h
> @@ -111,9 +111,6 @@ typedef struct mdtm_reassembly_queue {
>   
>   #define MDTM_NORMAL_MSG_FRAG_SIZE   1400
>   
> -#define MDTM_RECV_BUFFER_SIZE 
> ((MDS_DIRECT_BUF_MAXSIZE>MDTM_NORMAL_MSG_FRAG_SIZE)? \
> -                      
> (MDS_DIRECT_BUF_MAXSIZE+SUM_MDS_HDR_PLUS_MDTM_HDR_PLUS_LEN):(MDTM_NORMAL_MSG_FRAG_SIZE+SUM_MDS_HDR_PLUS_MDTM_HDR_PLUS_LEN))
> -
>   /* Prefixes and defines regarding to the MDS_TIPC*/
>   
>   #define MDS_TIPC_PREFIX         0x56000000
> diff --git a/osaf/libs/core/mds/mds_dt_tipc.c 
> b/osaf/libs/core/mds/mds_dt_tipc.c
> --- a/osaf/libs/core/mds/mds_dt_tipc.c
> +++ b/osaf/libs/core/mds/mds_dt_tipc.c
> @@ -637,7 +637,7 @@ static uint32_t mdtm_process_recv_events
>   
>                               /* Data Received */
>   
> -                             uint8_t inbuf[MDTM_RECV_BUFFER_SIZE];
[Surya] Following should be made as allocated memory as this is huge 
memory around 66k and should not be allocated on stack.
> +                             uint8_t inbuf[TIPC_MAX_USER_MSG_SIZE];
>                               uint8_t *data;  /* Used for decoding */
>                               uint16_t recd_bytes = 0;
>   #ifdef MDS_CHECKSUM_ENABLE_FLAG
>
> ------------------------------------------------------------------------------
> "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
> Instantly run your Selenium tests across 300+ browser/OS combos.  Get
> unparalleled scalability from the best Selenium testing platform available.
> Simple to use. Nothing to install. Get started now for free."
> http://p.sf.net/sfu/SauceLabs
> _______________________________________________
> Opensaf-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/opensaf-devel


------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.  Get 
unparalleled scalability from the best Selenium testing platform available.
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to