Summary: amfd V2: update RT objects during node-failover of active controller [#494]. Review request for Trac Ticket(s): #494 Peer Reviewer(s): Hans F., Nagendra Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): All Development branch: <<IF ANY GIVE THE REPO URL>>
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- In this second version, imm jobs are cleared after sending reboot message to AMFND. Also added a TODO for future handling. changeset 0ec7078bf72f36099624c6aa835936016444d9b0 Author: [email protected] Date: Sat, 10 May 2014 20:35:17 +0530 amfd V2: update RT objects during node-failover of active controller [#494]. Problem: Run time objects and attributes are not updated/deleted/created when node-failover gots escalated for active controller and standby controller took the active role. Reason: Activities related to update of runtime objects and certain attribute to IMM are given low priotiy and are pushed in Job queue by AMF. These jobs are completed when AMF is not busy in any other high priority activity. When node-failover is escalated, AMFD sends reboot message to AMFND to reboot the node. In case node-failover is escalated for active controller, it will send reboot message to AMFND which will reboot the controller. In such a case, some IMM related activites in JOB queue will remian uncompleted. All such activites should be compleleted before rebooting the active controller when node-failover is escalated for it. Fix: Patch will try to finish as many IMM related jobs as possbile just after sending reboot message to AMFND when node-failover is escalated for active controller. Complete diffstat: ------------------ osaf/services/saf/amf/amfd/sgproc.cc | 13 +++++++++++++ 1 files changed, 13 insertions(+), 0 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- Ack from Hans, Nagendra Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
