Ack with minor comments inline Thanks, Hans > -----Original Message----- > From: [email protected] [mailto:[email protected]] > Sent: den 10 maj 2014 17:13 > To: [email protected]; Hans Feldt > Cc: [email protected] > Subject: [PATCH 1 of 1] amfd V2: update RT objects during node-failover of > active controller [#494] > > osaf/services/saf/amf/amfd/sgproc.cc | 13 +++++++++++++ > 1 files changed, 13 insertions(+), 0 deletions(-) > > > Problem: Run time objects and attributes are not updated/deleted/created > when node-failover gots escalated for active controller and standby > controller took the active role. > > Reason: Activities related to update of runtime objects and certain > attribute to IMM are given low priotiy and are pushed in Job queue by AMF. > These jobs are completed when AMF is not busy in any other high priority > activity. When node-failover is escalated, AMFD sends reboot message to > AMFND to reboot the node. In case node-failover is escalated for active > controller, it will send reboot message to AMFND which will reboot the > controller. In such a case, some IMM related activites in JOB queue will > remian uncompleted. All such activites should be compleleted before > rebooting the active controller when node-failover is escalated for it. > > Fix: Patch will try to finish as many IMM related jobs as possbile just > after sending reboot message to AMFND when node-failover is escalated > for active controller. > > diff --git a/osaf/services/saf/amf/amfd/sgproc.cc > b/osaf/services/saf/amf/amfd/sgproc.cc > --- a/osaf/services/saf/amf/amfd/sgproc.cc > +++ b/osaf/services/saf/amf/amfd/sgproc.cc > @@ -529,6 +529,19 @@ void avd_su_oper_state_evh(AVD_CL_CB *cb > " repair > action", > > node->name.value); > avd_d2n_reboot_snd(node); > + > + AvdJobDequeueResultT job_res = > JOB_EXECUTED; [Hans] unnecessary assignment > + > + /* Finish as many IMM jobs as > possible because active > + controller is rebooting. > + > + TODO: All the pending IMM > related jobs should [Hans] TODO format: TODO(user) > + be handled by the standby > when it will become > + active after controller > fail-over. > + */ > + while (job_res == JOB_EXECUTED) > + job_res = > Fifo::execute(cb->immOiHandle); [Hans] ideally this should be a "flush" method on the job queue, add a TODO? > + > goto done; > } else { > avd_pg_node_csi_del_all(avd_cb, > node);
------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
