Hi zoran. Reviwed the patch series. Ack for the patch series.
/Neel. On Thursday 24 July 2014 01:50 PM, Zoran Milinkovic wrote: > Summary: imm: add support for long DN [#886] > Review request for Trac Ticket(s): 886 > Peer Reviewer(s): Neelakanta, Anders > Pull request to: Zoran > Affected branch(es): default(4.5) > Development branch: default(4.5) > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests y > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset b29dc6b34fa33948bf6e3d390ad908257fa353d6 > Author: Zoran Milinkovic <[email protected]> > Date: Thu, 24 Jul 2014 10:07:37 +0200 > > imm: add support for long DN to IMM service [#886] > > The patch contains a code for the support long DNs in IMM service > > changeset c65950deb0e2818a2225cea0cf51b2683514638e > Author: Zoran Milinkovic <[email protected]> > Date: Thu, 24 Jul 2014 10:08:50 +0200 > > imm: add support for long DN to IMM library [#886] > > The patch contains a code for the support long DNs in IMM library > > changeset a5d2bd5f66470876670e9d195c447a79c2a79267 > Author: Zoran Milinkovic <[email protected]> > Date: Thu, 24 Jul 2014 10:11:28 +0200 > > immtools: add support for long DN to IMM tools [#886] > > The patch contains a code for the support long DNs in IMM tools > > changeset 234bac18dcc49bd34e717bb415dad1c4d67a7910 > Author: Zoran Milinkovic <[email protected]> > Date: Thu, 24 Jul 2014 10:14:40 +0200 > > immtest: add test cases for long DN [#886] > > New test cases have been added to immomtest and immoitest. If > SA_ENABLE_EXTENDED_NAMES is not set, immomtest and immoitest can use > --longDn parameter to set SA_ENABLE_EXTENDED_NAMES for testing. Option > -h > and --help have been added to show the usage of immomtest and immoitest > > > Added Files: > ------------ > tests/immsv/implementer/test_saImmOiLongDn.c > tests/immsv/management/test_saImmOmLongDn.c > > > Complete diffstat: > ------------------ > osaf/libs/agents/saf/imma/Makefile.am | 4 +- > osaf/libs/agents/saf/imma/imma_cb.h | 1 + > osaf/libs/agents/saf/imma/imma_db.c | 3 + > osaf/libs/agents/saf/imma/imma_init.c | 28 ++++--- > osaf/libs/agents/saf/imma/imma_oi_api.c | 139 > ++++++++++++++++++-------------------- > osaf/libs/agents/saf/imma/imma_om_api.c | 228 > +++++++++++++++++++++++++++++++-------------------------------- > osaf/libs/agents/saf/imma/imma_proc.c | 134 > +++++++++++++++++++++++-------------- > osaf/libs/common/immsv/Makefile.am | 1 + > osaf/libs/common/immsv/immpbe_dump.cc | 30 +++---- > osaf/libs/common/immsv/immsv_evt.c | 134 > ++++++++++++++++++++++++++++--------- > osaf/libs/common/immsv/include/immsv_api.h | 5 + > osaf/services/saf/immsv/config/immnd.conf | 3 + > osaf/services/saf/immsv/immd/Makefile.am | 2 +- > osaf/services/saf/immsv/immd/immd_amf.c | 3 +- > osaf/services/saf/immsv/immd/immd_evt.c | 3 +- > osaf/services/saf/immsv/immloadd/Makefile.am | 1 + > osaf/services/saf/immsv/immloadd/imm_loader.cc | 54 ++++++-------- > osaf/services/saf/immsv/immnd/ImmModel.cc | 245 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------ > osaf/services/saf/immsv/immnd/Makefile.am | 2 +- > osaf/services/saf/immsv/immnd/immnd_amf.c | 3 +- > osaf/services/saf/immsv/immnd/immnd_evt.c | 36 +++++---- > osaf/services/saf/immsv/immnd/immnd_proc.c | 6 +- > osaf/services/saf/immsv/immpbed/Makefile.am | 1 + > osaf/services/saf/immsv/immpbed/immpbe_daemon.cc | 130 > ++++++++++++++++++------------------ > osaf/tools/safimm/immadm/Makefile.am | 1 + > osaf/tools/safimm/immadm/imm_admin.c | 14 +-- > osaf/tools/safimm/immcfg/Makefile.am | 1 + > osaf/tools/safimm/immcfg/imm_cfg.c | 22 +++-- > osaf/tools/safimm/immcfg/imm_import.cc | 61 > +++++++++------- > osaf/tools/safimm/immdump/Makefile.am | 1 + > osaf/tools/safimm/immdump/imm_xmlw_dump.cc | 10 +- > osaf/tools/safimm/immfind/Makefile.am | 1 + > osaf/tools/safimm/immfind/imm_find.c | 16 +-- > osaf/tools/safimm/immlist/Makefile.am | 1 + > osaf/tools/safimm/immlist/imm_list.c | 8 +- > osaf/tools/safimm/src/immutil.c | 92 > +++++++++++++++---------- > tests/immsv/common/immtest.c | 60 > ++++++++++++++-- > tests/immsv/implementer/Makefile.am | 1 + > tests/immsv/implementer/applier.c | 24 +++-- > tests/immsv/implementer/test_cleanup.c | 38 ++++++--- > tests/immsv/implementer/test_saImmOiLongDn.c | 621 > ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > tests/immsv/implementer/test_saImmOiRtObjectCreate_2.c | 10 ++- > tests/immsv/management/Makefile.am | 1 + > tests/immsv/management/test_cleanup.c | 38 ++++++--- > tests/immsv/management/test_saImmOmLongDn.c | 368 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 45 files changed, 1968 insertions(+), 617 deletions(-) > > > Testing Commands: > ----------------- > immomtest > immomtest --longDn > > immoitest > immoitest --longDn > > > Testing, Expected Results: > -------------------------- > All tests must pass > > > Conditions of Submission: > ------------------------- > Ack from Neelakanta and Anders > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
