On 2015-06-03 15:48, Johan Mårtensson O wrote: > Actually just realized that you have done some double work that I had already > done. I had considered the import/creation of comptypes and friends to be > something done once in the lifetime of a cluster lifetime. That justified the > need to a specific tool for that. Thus I saw no point in adding it to the sam > tool itself. > > OCF import is implemented in the ocf-import-ra script. The problem with that > is that uses the "amf-comptype create" command. > > I still think this is a good idea and would contribute to keep the sam tool > small(er) > Johan: I think it helps discoverability to have this in the sam tool. At the > same time, the number of commands supported by sam can grow too large if we > keep adding more functions. If sam gets too big we can split out embedded > commands to individual scripts. > What do you think?
I guess we have to look at the workflows, who, why and when. Low level AMF types are related with SW packages. This because the resource types are implemented in scripts packaged in SW packages. So managing these types go together with administering SW packages. The stuff that ocf-import-ra (and your new stuff) does is done internally/automatically by pacemaker. No human involved. So I think such functionality can be split out. Not sure I get what you mean by "discoverability" but the command could be prefixed "sam-" if that helps. The rest of sam's functionality is about managing AMF workloads. Done rather seldom, except for admin commands possibly used in upgrades. /Hans ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
