Summary: amfd: convert list_of_su to std::set [#1142] Review request for Trac Ticket(s): 1142 Peer Reviewer(s): AMF devs Pull request to: AMF maintainers Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 091bd022e1f149f1fa477991f63dcc01a56c1bfb Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] changeset 4e2075a9862afc3c68c9e8f97a3ec8741d2f73b4 Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: add TRACE_LEAVE calls [#1149] changeset e45011b7792932103248563be1bacb3dff00dc27 Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] changeset b896a5d3138b5f35764e0fb0354c1768add27690 Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] changeset a556a386beb7fcbef0caa9b2916da3a37a8253ed Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] changeset d4655a48d5b58f90313bccf02a5e60b1f675a3db Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] changeset 480746b1effed6068ad8ed56fd9c471f33baffc2 Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] changeset 6a6475a53c6b7490be9043e3ef465d651ef5f810 Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] changeset aeca269f2e82e1f195441a189544c37de785e7d6 Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] changeset ab7180ae0ef07521e33a0dbaa4ba7971036a1214 Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] changeset 7044b0d7f9947b414076cf5973e1d2ec6eb3c2b4 Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] changeset 2e5ca56bf7a336b5664dff2364a5543f05aee702 Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] changeset b620208cc109b86c14d6de35df0bfa22899d5842 Author: Gary Lee <[email protected]> Date: Thu, 30 Jul 2015 12:06:09 +1000 amfd: convert list_of_su to std::set [#1142] Complete diffstat: ------------------ osaf/services/saf/amf/amfd/cluster.cc | 2 +- osaf/services/saf/amf/amfd/include/sg.h | 14 +++- osaf/services/saf/amf/amfd/include/su.h | 15 ++++- osaf/services/saf/amf/amfd/ndfsm.cc | 3 + osaf/services/saf/amf/amfd/node.cc | 8 +- osaf/services/saf/amf/amfd/nodegroup.cc | 4 +- osaf/services/saf/amf/amfd/sg.cc | 175 +++++++++++++++++++++++++++---------------------------- osaf/services/saf/amf/amfd/sg_2n_fsm.cc | 98 +++++++++++++----------------- osaf/services/saf/amf/amfd/sg_nored_fsm.cc | 69 ++++++--------------- osaf/services/saf/amf/amfd/sg_npm_fsm.cc | 240 ++++++++++++++++++++++++++++++++++++--------------------------------------- osaf/services/saf/amf/amfd/sg_nway_fsm.cc | 53 ++++++++++------ osaf/services/saf/amf/amfd/sg_nwayact_fsm.cc | 49 ++++++-------- osaf/services/saf/amf/amfd/sgproc.cc | 27 +++----- osaf/services/saf/amf/amfd/su.cc | 5 +- osaf/services/saf/amf/amfd/util.cc | 10 ++- 15 files changed, 373 insertions(+), 399 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
