Hi Mahesh, We don't have any test case. The case with receiving 0 bytes is not easy to reproduce. Missing mutex unlock was noticed when we worked on a resource leak in IMM/MDS.
Best regards, Zoran -----Original Message----- From: A V Mahesh [mailto:[email protected]] Sent: Wednesday, September 23, 2015 6:10 AM To: Zoran Milinkovic Cc: [email protected] Subject: Re: [PATCH 1 of 1] mds: unlock mutex when 0 bytes is read from TIPC socket [#1497] Hi Zoran, ACK form me , Not tested. By the way In which participial case you are getting Zero bytes message (How do you reproduce ) ? Can you please share the Application that sends Zero bytes if you have , I may required in some other testing. -AVM On 9/22/2015 5:57 PM, Zoran Milinkovic wrote: > osaf/libs/core/mds/mds_dt_tipc.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > > Unlock mutex when 0 bytes is read from TIPC connection > > diff --git a/osaf/libs/core/mds/mds_dt_tipc.c > b/osaf/libs/core/mds/mds_dt_tipc.c > --- a/osaf/libs/core/mds/mds_dt_tipc.c > +++ b/osaf/libs/core/mds/mds_dt_tipc.c > @@ -739,6 +739,7 @@ static uint32_t mdtm_process_recv_events > (struct sockaddr > *)&client_addr, &alen); > if (recd_bytes == 0) { > m_MDS_LOG_DBG("MDTM: recd bytes=0 on > received on sock, > abnormal/unknown/hack condition. Ignoring"); > + > osaf_mutex_unlock_ordie(&gl_mds_library_mutex); > continue; > } > data = inbuf; ------------------------------------------------------------------------------ Monitor Your Dynamic Infrastructure at Any Scale With Datadog! Get real-time metrics from all of your servers, apps and tools in one place. SourceForge users - Click here to start your Free Trial of Datadog now! http://pubads.g.doubleclick.net/gampad/clk?id=241902991&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
