Praveen is on leave. If there are no comments on this patch series today, then I will push it today.
Thanks -Nagu > -----Original Message----- > From: Praveen Malviya > Sent: 10 September 2015 19:33 > To: [email protected]; Nagendra Kumar; > [email protected] > Cc: [email protected] > Subject: [PATCH 0 of 3] Review Request for #315, #334 and #1455 v1 [#315, > #334, #1455]. > > Summary: Review request for #315, #334 and #1455 v1 [#315,#334, #1455]. > Review request for Trac Ticket(s): #315 #334 and #1455 Peer Reviewer(s): > AMF contributors. > Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected > branch(es): default for #334 and #1455 and 4.5 for #315. > Development branch: <<IF ANY GIVE THE REPO URL>> > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > This is version1 with minimal testing of positive cases. > Need to clear minor TODO list. > Continuing with testing.... > > changeset 971b109343dccff5c62c7558c082d9691233ecf1 > Author: [email protected] > Date: Thu, 10 Sep 2015 19:23:03 +0530 > > amf: fix spec deviation of surestart escalation [#315] > > During surestart recovery, currently AMF is not spec compliant in two > ways: > 1)Individual component is terminated/cleaned up and then > instantiated. > Iinstead all componenets should be abruplty terminated and then > instantiated > honoring the instantiation level. 2)During termination/cleanup of > individual > component, saAmfDisableRestart flag is not honoured. Ticket is > updated > with relevent spec sections for reference. > > Patch solves the problem by cleaning up the component in the > reverse order > of instantiation level and instantiation of compoment in the forward > order. > Also before terminating a non-restartable component > (saAmfDisableRestart=true), assignments are switchover to another > SU. > > This patch contains the common code to be used by #334 and #1455. > > changeset 644805e33508b0660c652bafbab6deb994e410a8 > Author: [email protected] > Date: Thu, 10 Sep 2015 19:23:28 +0530 > > amf: support RESTART admin op on non-restartable component > [#334] > > AMF currently support admin restart operation on a restartable > component(for > which saAmfDisableRestart=false). > > Patch supports it on a non-restartable component. Patch for #315 > contains > changes in amfnd and amfd which are common for all the three > tickets viz. > #315, #334 and #1455. > > TODO: To take care of controller role change when operation in > progress. > > changeset a302365f232bee974cccb8c032d13a8a83d37f27 > Author: [email protected] > Date: Thu, 10 Sep 2015 19:23:56 +0530 > > amf: support RESTART admin op on su [#1455] > > Admin operation is supported for both restartable and non- > restartable su. > Patch for #315 contains changes in amfnd and amfd which are > common for all > the three tickets viz. #315, #334 and #1455. > > TODO: To take care of controller role change when operation in > progress. > > > Complete diffstat: > ------------------ > osaf/services/saf/amf/amfd/comp.cc | 62 ++- > osaf/services/saf/amf/amfd/include/su.h | 8 + > osaf/services/saf/amf/amfd/ndproc.cc | 150 ++++++++- > osaf/services/saf/amf/amfd/sgproc.cc | 90 +++++- > osaf/services/saf/amf/amfd/su.cc | 144 +++++++++- > osaf/services/saf/amf/amfnd/clc.cc | 223 ++++++++++++- > osaf/services/saf/amf/amfnd/comp.cc | 58 ++- > osaf/services/saf/amf/amfnd/compdb.cc | 1 + > osaf/services/saf/amf/amfnd/err.cc | 148 +++++++- > osaf/services/saf/amf/amfnd/include/avnd_err.h | 1 + > osaf/services/saf/amf/amfnd/include/avnd_su.h | 8 +- > osaf/services/saf/amf/amfnd/su.cc | 79 ++++- > osaf/services/saf/amf/amfnd/susm.cc | 915 > +++++++++++++++++++++++++++++++++++++++++++++++----------- > 13 files changed, 1591 insertions(+), 296 deletions(-) > > > Testing Commands: > ----------------- > Tested surestart recovery escalation for PI, NPI configuration. > Tested admin opreration on restartable and non-restartable component in 2 > component confs in all red models.. > Tested admin opreration on restartable and non-restartable PI, NPI and > Mixed SU in 2 component confs in all red models.. > > > Testing, Expected Results: > -------------------------- > All basic cases are working fine. > > Conditions of Submission: > ------------------------- > Ack from reviewers before FC tag of 4.7 > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your > headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
