Hi Hung, Was there any problem with not releasing admin owner on IMM object ?
IMM test should not release admin owner on IMM object. It may accidentally release admin owner on ongoing operation on IMM object. I have to NACK this patch. I think that the ticket is not valid, and if there is no valid reason for releasing admin owner, the ticket can be closed with status 'invalid'. Thanks, Zoran -----Original Message----- From: Hung Nguyen [mailto:[email protected]] Sent: Thursday, February 04, 2016 8:59 AM To: Zoran Milinkovic; [email protected] Cc: [email protected] Subject: [PATCH 1 of 1] imm: Release adminowner of IMM object for immoitest [#1667] tests/immsv/implementer/test_saImmOiImplementerSet.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) Release adminowner of IMM object for immoitest. diff --git a/tests/immsv/implementer/test_saImmOiImplementerSet.c b/tests/immsv/implementer/test_saImmOiImplementerSet.c --- a/tests/immsv/implementer/test_saImmOiImplementerSet.c +++ b/tests/immsv/implementer/test_saImmOiImplementerSet.c @@ -368,6 +368,7 @@ void saImmOiImplementerSet_10(void) safassert(saImmOmAdminOwnerInitialize(immHandle, "safImmService", SA_FALSE, &ownerHandle), SA_AIS_OK); safassert(saImmOmAdminOwnerSet(ownerHandle, immObjs, SA_IMM_ONE), SA_AIS_OK); safassert(saImmOmAdminOperationInvoke_2(ownerHandle, &immObj, 1, 2, params, &err, 100), SA_AIS_OK); + safassert(saImmOmAdminOwnerRelease(ownerHandle, immObjs, SA_IMM_ONE), SA_AIS_OK); safassert(saImmOmAdminOwnerFinalize(ownerHandle), SA_AIS_OK); safassert(saImmOmAdminOwnerInitialize(immHandle, (const SaImmAdminOwnerNameT)__FUNCTION__, SA_TRUE, &ownerHandle), SA_AIS_OK); @@ -388,6 +389,7 @@ void saImmOiImplementerSet_10(void) safassert(saImmOmAdminOwnerInitialize(immHandle, "safImmService", SA_FALSE, &ownerHandle), SA_AIS_OK); safassert(saImmOmAdminOwnerSet(ownerHandle, immObjs, SA_IMM_ONE), SA_AIS_OK); safassert(saImmOmAdminOperationInvoke_2(ownerHandle, &immObj, 1, 1, params, &err, 100), SA_AIS_OK); + safassert(saImmOmAdminOwnerRelease(ownerHandle, immObjs, SA_IMM_ONE), SA_AIS_OK); safassert(saImmOmAdminOwnerFinalize(ownerHandle), SA_AIS_OK); safassert(saImmOmFinalize(immHandle), SA_AIS_OK); ------------------------------------------------------------------------------ Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month Monitor end-to-end web transactions and take corrective actions now Troubleshoot faster and improve end-user experience. Signup Now! http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
