Hi Zoran, immoitest changes the adm owner of opensafImm object.
# immlist -a SaImmAttrAdminOwnerName opensafImm=opensafImm,safApp=safImmService SaImmAttrAdminOwnerName=IMMLOADER # immoitest 2 32 # immlist -a SaImmAttrAdminOwnerName opensafImm=opensafImm,safApp=safImmService SaImmAttrAdminOwnerName=safImmService Normally, the testcases will create their own objects to test, and leave existing objects untouched. The general idea is to keep everything the same before and after running tests. I think the opensafImm object should be no exception. The test cases should not change its admin owner. BR, Hung Nguyen - DEK Technologies -------------------------------------------------------------------------------- From: Zoran Milinkovic [email protected] Sent: Wednesday, March 16, 2016 9:05PM To: Hung Nguyen, Anders Bjornerstedt [email protected], [email protected] Cc: Opensaf-devel [email protected] Subject: RE: [devel] [PATCH 1 of 1] imm: Release adminowner of IMM object for immoitest [#1667] Hi Hung, I would rather move check and release admin owner to startup() and clean() functions than releasing "safImmService" admin owner on "opensafImm=opensafImm,safApp=safImmService" in tests. Is there any problem with no releasing of the admin owner ? Thanks, Zoran -----Original Message----- From: Hung Nguyen [mailto:[email protected]] Sent: Monday, February 15, 2016 8:26 AM To: Zoran Milinkovic; [email protected] Cc: [email protected] Subject: Re: [devel] [PATCH 1 of 1] imm: Release adminowner of IMM object for immoitest [#1667] Hi Zoran, I forgot that IMM service needs admin ownership for IMM object for 2PBE to work. So in case of 2PBE, this patch doesn't work. But in other cases (0PBE or 1PBE), normally the IMM object is not owned by IMM service. We don't need to keep the admin ownership for IMM object. Adminowner of IMM object before and after the testcases must be the same. If a testcase involving IMM object, it must do some check before setting admo for IMM object. 1) If IMM object has no admo (IMMLOADER or <Empty>), we initialize with ROF set to true. 2) If IMM object already has a admo (can be whatever, doesn't have to be 'safImmService'), we initialize admo handle with exact same name and ROF is false. It is not obligatory to use 'safImmService' as admo name for IMM object. We can use a different name, like when using immcfg, immcfg will use a random admo name. immcfg -a longDnsAllowed=1 opensafImm=opensafImm,safApp=safImmService So the point here is to keep the admo for IMM object as the same with before running the testcases. If you agree with me I will change the description of the ticket and send a new patch for review. BR, Hung Nguyen - DEK Technologies -------------------------------------------------------------------------------- From: Zoran Milinkovic [email protected] Sent: Tuesday, February 09, 2016 7:13PM To: Anders Bjornerstedt, Hung Nguyen [email protected], [email protected] Cc: Opensaf-devel [email protected] Subject: RE: [devel] [PATCH 1 of 1] imm: Release adminowner of IMM object for immoitest [#1667] Hi Anders, The test is about testing IMM OpenSAF 4.5 protocol, and the test disable and enable IMM OpenSAF 4.5 features. So, there should be admin ops on IMM objects. 'saImmService' admin owner name is used for disabling and enabling IMM features in the test, which is standard IMM admin owner name used on IMM object There is no need for releasing 'saImmService' admin owner. Same works for immadm on IMM object. 'saImmService' admin owner is not released after calling admin op on IMM objects. BR, Zoran -----Original Message----- From: [email protected] [mailto:[email protected]] Sent: Tuesday, February 09, 2016 12:47 PM To: Zoran Milinkovic; Hung Duc Nguyen Cc: [email protected] Subject: Re: [devel] [PATCH 1 of 1] imm: Release adminowner of IMM object for immoitest [#1667] Hi Zoran and Hung, Just a small comment on this. Note that an IMMA OM client can get admin-owner released automatically at admo-handle-close or process termination, if you set the parameter "ReleaseOwnershipOnFinalize" to SA_TRUE in the adminOwnerInitialize API. In general the imma tests should be fixed to always use their own test objects (and never (ab)use regular/normal IMM objects for the testing). Such test objects are created by the test framework and destroyed by the test framework. /AndersBj > ----Ursprungligt meddelande---- > Från : [email protected] > Datum : 2016-02-09 - 10:19 (GMT) > Till : [email protected], [email protected] Kopia > : [email protected] > Ämne : Re: [devel] [PATCH 1 of 1] imm: Release adminowner of IMM > object for immoitest [#1667] > > Hi Hung, > > Was there any problem with not releasing admin owner on IMM object ? > > IMM test should not release admin owner on IMM object. It may accidentally > release admin owner on ongoing operation on IMM object. > > I have to NACK this patch. > I think that the ticket is not valid, and if there is no valid reason for > releasing admin owner, the ticket can be closed with status 'invalid'. > > Thanks, > Zoran > > -----Original Message----- > From: Hung Nguyen [mailto:[email protected]] > Sent: Thursday, February 04, 2016 8:59 AM > To: Zoran Milinkovic; [email protected] > Cc: [email protected] > Subject: [PATCH 1 of 1] imm: Release adminowner of IMM object for > immoitest [#1667] > > tests/immsv/implementer/test_saImmOiImplementerSet.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > > Release adminowner of IMM object for immoitest. > > diff --git a/tests/immsv/implementer/test_saImmOiImplementerSet.c > b/tests/immsv/implementer/test_saImmOiImplementerSet.c > --- a/tests/immsv/implementer/test_saImmOiImplementerSet.c > +++ b/tests/immsv/implementer/test_saImmOiImplementerSet.c > @@ -368,6 +368,7 @@ void saImmOiImplementerSet_10(void) > safassert(saImmOmAdminOwnerInitialize(immHandle, "safImmService", > SA_FALSE, &ownerHandle), SA_AIS_OK); > safassert(saImmOmAdminOwnerSet(ownerHandle, immObjs, SA_IMM_ONE), > SA_AIS_OK); > safassert(saImmOmAdminOperationInvoke_2(ownerHandle, &immObj, 1, 2, > params, &err, 100), SA_AIS_OK); > + safassert(saImmOmAdminOwnerRelease(ownerHandle, immObjs, > +SA_IMM_ONE), SA_AIS_OK); > safassert(saImmOmAdminOwnerFinalize(ownerHandle), SA_AIS_OK); > > safassert(saImmOmAdminOwnerInitialize(immHandle, (const > SaImmAdminOwnerNameT)__FUNCTION__, SA_TRUE, &ownerHandle), SA_AIS_OK); @@ > -388,6 +389,7 @@ void saImmOiImplementerSet_10(void) > safassert(saImmOmAdminOwnerInitialize(immHandle, "safImmService", > SA_FALSE, &ownerHandle), SA_AIS_OK); > safassert(saImmOmAdminOwnerSet(ownerHandle, immObjs, SA_IMM_ONE), > SA_AIS_OK); > safassert(saImmOmAdminOperationInvoke_2(ownerHandle, &immObj, 1, 1, > params, &err, 100), SA_AIS_OK); > + safassert(saImmOmAdminOwnerRelease(ownerHandle, immObjs, > +SA_IMM_ONE), SA_AIS_OK); > safassert(saImmOmAdminOwnerFinalize(ownerHandle), SA_AIS_OK); > > safassert(saImmOmFinalize(immHandle), SA_AIS_OK); > > ---------------------------------------------------------------------- > - > ------- > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 > _______________________________________________ > Opensaf-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/opensaf-devel > ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785231&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
