Summary:leap: provide ensured disk space option for shm_open request [1712] Review request for Trac Ticket(s): #1712 Peer Reviewer(s): Anders Widell / Ramesh Pull request to: <<LIST THE PERSON WITH PUSH ACCESS HERE>> Affected branch(es): 4.7 , 5.0 and defult Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries y Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 3e8911b92471e53d8a411c15e75a11ed0d1bec30 Author: A V Mahesh <[email protected]> Date: Fri, 01 Apr 2016 11:10:14 +0530 leap: provide ensured disk space option for shm_open request [1712] Provided ensured disk space is allocated for NCS_OS_POSIX_SHM_REQ_OPEN request using posix_fallocate() so that application such as CPSV subsequent writes to bytes in the specified range are guaranteed not to fail because of lack of disk space. Updated the Opensaf services according to new options based on requirements . Complete diffstat: ------------------ osaf/libs/core/include/ncs_osprm.h | 1 + osaf/libs/core/leap/os_defs.c | 13 ++++++++++--- osaf/services/saf/cpsv/cpnd/cpnd_proc.c | 1 + osaf/services/saf/cpsv/cpnd/cpnd_res.c | 2 ++ osaf/services/saf/glsv/glnd/glnd_shm.c | 1 + osaf/services/saf/mqsv/mqnd/mqnd_shm.c | 1 + 6 files changed, 16 insertions(+), 3 deletions(-) Testing Commands: ----------------- If `open.ensures_space = true` is configured for NCS_OS_POSIX_SHM_REQ_OPEN request will now returned SA_AIS_ERR_NO_RESOURCES , for example if application calls saCkptCheckpointOpen() with lgrg size and less shm space. log error :` ER posix_shm:posix_fallocate failed() with not enough space left ENOSPC: 28` Testing, Expected Results: -------------------------- S_OS_POSIX_SHM_REQ_OPEN should work fine. Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Transform Data into Opportunity. Accelerate data analysis in your applications with Intel Data Analytics Acceleration Library. Click to learn more. http://pubads.g.doubleclick.net/gampad/clk?id=278785471&iu=/4140 _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
