Summary: plm: disallow activation of blade if it is operationally disabled Review request for Trac Ticket(s): 1751 Peer Reviewer(s): Mathi Pull request to: Mathi Affected branch(es): default, 4.7, 4.6 Development branch:
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- I think this is a better patch than the one I previously posted. The previous patch was returning TRY_AGAIN if the isolate failed. After looking more closely at the PLM spec, I think if isolation fails ReadinessImpact should return AIS_OK (as it is currently doing), and isolate-pending flag is set. There is no ERR_DEPLOYMENT return code for ReadinessImpact. As long as we prevent an HE from activating while in disabled state, I think it's ok. changeset 67a619b5c93efc2baa46c042fd01591927da93a8 Author: Alex Jones <[email protected]> Date: Tue, 26 Apr 2016 09:21:55 -0400 plm: disallow activation of blade if it is operationally disabled [#1751] Blade that is disabled is allowed to activate. PICMG 3.0 states that shelf managers should deactivate a FRU if it has a non-recoverable sensor assertion. After deactivating the FRU, some shelf managers will attempt to reactivate the FRU. PLM should disallow activation of a FRU that is operationally disabled. The REPAIRED admin operation should be used if the admin wants to activate the FRU. Complete diffstat: ------------------ osaf/services/saf/plmsv/plms/plms_he_pres_fsm.c | 12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) Testing Commands: ----------------- 1) set a non-recoverable sensor, so that the shelf manager will power down the FRU (you can probably simulate this by initiating extraction pending) 2) before the deactivation completes, call ReadinessImpact with RI_FAILURE 3) if simulating, once the blade has deactivated, attempt to activate it again Testing, Expected Results: -------------------------- 1) blade should remain in inactive state with no readiness flags set 2) attempts to activate the blade, should result in deactivations Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
