Ack, This fits the SAF Admin state model too. Could you update the ticket with this approach instead of the v1 patch. Will push it tomorrow. Thanks, Mathi.
> -----Original Message----- > From: Alex Jones [mailto:[email protected]] > Sent: Tuesday, April 26, 2016 7:03 PM > To: Mathivanan Naickan Palanivelu > Cc: [email protected] > Subject: [PATCH 1 of 1] plm: disallow activation of blade if it is > operationally > disabled [#1751] > > osaf/services/saf/plmsv/plms/plms_he_pres_fsm.c | 12 ++++++++++++ > 1 files changed, 12 insertions(+), 0 deletions(-) > > > Blade that is disabled is allowed to activate. > > PICMG 3.0 states that shelf managers should deactivate a FRU if it has a non- > recoverable sensor assertion. After deactivating the FRU, some shelf > managers will attempt to reactivate the FRU. > > PLM should disallow activation of a FRU that is operationally disabled. The > REPAIRED admin operation should be used if the admin wants to activate the > FRU. > > diff --git a/osaf/services/saf/plmsv/plms/plms_he_pres_fsm.c > b/osaf/services/saf/plmsv/plms/plms_he_pres_fsm.c > --- a/osaf/services/saf/plmsv/plms/plms_he_pres_fsm.c > +++ b/osaf/services/saf/plmsv/plms/plms_he_pres_fsm.c > @@ -191,6 +191,18 @@ static SaUint32T plms_HE_inact_np_to_ins > > plms_presence_state_set(ent,SA_PLM_HE_PRESENCE_ACTIVATING > ,NULL, > SA_NTF_OBJECT_OPERATION, > > SA_PLM_NTFID_STATE_CHANGE_ROOT); > + > + /* If entity is disabled don't allow activation */ > + if (ent->entity.he_entity.saPlmHEOperationalState == > + SA_PLM_OPERATIONAL_DISABLED) > + { > + LOG_ER("Refusing to activate as the entity is in DISABLED" > + " operational state: %s", ent->dn_name_str); > + > + ret_err = plms_ent_isolate(ent, false, false); > + return ret_err; > + } > + > /* If admin state is lckinact, then move this entity back to inact > state.*/ > if (SA_PLM_HE_ADMIN_LOCKED_INACTIVE == > ------------------------------------------------------------------------------ Find and fix application performance issues faster with Applications Manager Applications Manager provides deep performance insights into multiple tiers of your business applications. It resolves application problems quickly and reduces your MTTR. Get your free trial! https://ad.doubleclick.net/ddm/clk/302982198;130105516;z _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
