Tx for pointing out.
But I see that it is returning from there.
In my patch it works as continue.
Can you please check once.

Since the test steps was not mentioned, so was not sure about the patch review.

Tx

----- Original Message -----
From: [email protected]
To: [email protected], [email protected], 
[email protected], [email protected]
Cc: [email protected]
Sent: Wednesday, May 11, 2016 4:27:48 PM GMT +05:30 Chennai, Kolkata, Mumbai, 
New Delhi
Subject: Re: [PATCH 1 of 1] amfd: avoid null pointer access [#1823]

Hi Nagu,

this is already handled by ticket #1766 and a patch was sent out April 
15. /Thanks HansN

On 05/11/2016 11:28 AM, [email protected] wrote:
>   osaf/services/saf/amf/amfd/nodegroup.cc |  4 ++++
>   1 files changed, 4 insertions(+), 0 deletions(-)
>
>
> Amfd is crashing because of null pointer acceess.
> This can happen if the node is removed from nodegroup
> at Act Amfd, but not removed at Standby Amfd.
> But node was deleted from both Act and Standby Amfd.
>
> diff --git a/osaf/services/saf/amf/amfd/nodegroup.cc 
> b/osaf/services/saf/amf/amfd/nodegroup.cc
> --- a/osaf/services/saf/amf/amfd/nodegroup.cc
> +++ b/osaf/services/saf/amf/amfd/nodegroup.cc
> @@ -467,6 +467,8 @@ static SaAisErrorT ng_ccb_completed_dele
>               ++iter) {
>   
>               node = avd_node_get(*iter);
> +             if (node == nullptr)
> +                     continue;
>               
>               TRACE("%s", node->name.value);
>   
> @@ -585,6 +587,8 @@ static void ng_ccb_apply_delete_hdlr(Ccb
>               for (std::set<std::string>::const_iterator iter = 
> ng->saAmfNGNodeList.begin();
>                               iter != ng->saAmfNGNodeList.end(); ++iter) {
>                       AVD_AVND *node = avd_node_get(*iter);
> +                     if (node == nullptr)
> +                             continue;
>                       node->admin_ng = nullptr;
>                       node->su_cnt_admin_oper = 0;
>               }


------------------------------------------------------------------------------
Mobile security can be enabling, not merely restricting. Employees who
bring their own devices (BYOD) to work are irked by the imposition of MDM
restrictions. Mobile Device Manager Plus allows you to control only the
apps on BYO-devices by containerizing them, leaving personal data untouched!
https://ad.doubleclick.net/ddm/clk/304595813;131938128;j
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to