Summary: mds: Use osaftransportd for writing MDS log messages [#2015] rebased
Review request for Trac Ticket(s): 2015
Peer Reviewer(s): Mahesh
Pull request to:
Affected branch(es): default(5.2)
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries y
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
rebased: Changes since last review request: re-based patch 3 so that it can be
applied after ticket [#2091] was pushed.
changeset 6f49da07674f2e9e16c7195b2f22187e831f71eb
Author: Anders Widell <[email protected]>
Date: Tue, 08 Nov 2016 14:57:35 +0100
mds: Convert the mds_log.c file to C++ [#2015]
Convert the mds_log.c file to C++ so that it can use C++ classes
without the
need for any wrappers.
changeset 025f1c0b9160908b0460e7f36a270cbcfb40d7a9
Author: Anders Widell <[email protected]>
Date: Tue, 08 Nov 2016 14:57:40 +0100
mds: Use osaftransportd for writing MDS log messages [#2015]
Instead of writing MDS log messages to a file directly from inside the
MDS
code, send the log messages to the osaftransportd process using a UNIX
socket.
changeset aca6312a2e8c54805802072d8d6a04c84d54f196
Author: Anders Widell <[email protected]>
Date: Tue, 08 Nov 2016 14:57:44 +0100
dtm: Implement an MDS log server [#2015]
Add a new thread that reads MDS log messages from a UNIX socket and
writes
them to disk. Rotate the MDS log file when it exceeds the maximum file
size
limit.
Complete diffstat:
------------------
osaf/libs/core/mds/Makefile.am | 2 +-
osaf/libs/core/mds/include/mds_dt2c.h | 3 -
osaf/libs/core/mds/include/mds_log.h | 59
+++++++++++-------
osaf/libs/core/mds/mds_dt_tipc.c | 5 +-
osaf/libs/core/mds/mds_log.cc | 412
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------------
osaf/libs/core/mds/mds_main.c | 6 +-
osaf/services/infrastructure/dtms/scripts/osaf-transport.in | 2 +
osaf/services/infrastructure/dtms/transport/Makefile.am | 4 +
osaf/services/infrastructure/dtms/transport/log_server.cc | 62
+++++++++++++++++++
osaf/services/infrastructure/dtms/transport/log_server.h | 49
+++++++++++++++
osaf/services/infrastructure/dtms/transport/log_writer.cc | 111
+++++++++++++++++++++++++++++++++++
osaf/services/infrastructure/dtms/transport/log_writer.h | 68
+++++++++++++++++++++
osaf/services/infrastructure/dtms/transport/main.cc | 113
+++++++++++++++++++++++++++++------
osaf/services/infrastructure/dtms/transport/transport_monitor.cc | 61
+++----------------
osaf/services/infrastructure/dtms/transport/transport_monitor.h | 17 +---
15 files changed, 665 insertions(+), 309 deletions(-)
Testing Commands:
-----------------
Build and start OpenSAF.
Testing, Expected Results:
--------------------------
OpenSAF MDS logging should work as before.
Conditions of Submission:
-------------------------
Ack from reviewer(s).
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 y y
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Developer Access Program for Intel Xeon Phi Processors
Access to Intel Xeon Phi processor-based developer platforms.
With one year of Intel Parallel Studio XE.
Training and support from Colfax.
Order your platform today. http://sdm.link/xeonphi
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
