Ack, code review only/Thanks HansN

-----Original Message-----
From: Gary Lee 
Sent: den 11 november 2016 06:47
To: Gary Lee <gary....@dektech.com.au>; praveen.malv...@oracle.com; Minh Hon 
Chau <minh.c...@dektech.com.au>; Hans Nordebäck <hans.nordeb...@ericsson.com>; 
nagendr...@oracle.com; Long Hong Buu Nguyen <long.hb.ngu...@dektech.com.au>
Cc: opensaf-devel@lists.sourceforge.net
Subject: [PATCH 1 of 1] amfnd: send node_up even if led_state is not green

 osaf/services/saf/amf/amfnd/di.cc |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)


if amfd restarts before set_leds is received by amfnd, then amfnd will not send 
node_up. amfnd should send node_up even if led state is not green.

diff --git a/osaf/services/saf/amf/amfnd/di.cc 
b/osaf/services/saf/amf/amfnd/di.cc
--- a/osaf/services/saf/amf/amfnd/di.cc
+++ b/osaf/services/saf/amf/amfnd/di.cc
@@ -562,13 +562,12 @@ uint32_t avnd_evt_mds_avd_up_evh(AVND_CB
                 */
                if (evt->info.mds.i_change == NCSMDS_NEW_ACTIVE && 
cb->is_avd_down) {
                        if (cb->led_state == AVND_LED_STATE_GREEN) {
-                               LOG_NO("Sending node up due to 
NCSMDS_NEW_ACTIVE");
-
                                // node_up, sync sisu, compcsi info to AVND for 
recovery
                                avnd_sync_sisu(cb);
                                avnd_sync_csicomp(cb);
-                               avnd_send_node_up_msg();
                        }
+                       LOG_NO("Sending node up due to NCSMDS_NEW_ACTIVE");
+                       avnd_send_node_up_msg();
                }
                cb->is_avd_down = false;
        }

------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to