Summary: log: Fix build failure on openSUSE 42.2 [#2208] Review request for Trac Ticket(s): 2208 Peer Reviewer(s): Mahesh, Madhurika, Lennart, Vu Pull request to: Affected branch(es): default(5.2) Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset fe5426acb0dfa54b653f0ff9bea00c94aacfc276 Author: Anders Widell <[email protected]> Date: Fri, 25 Nov 2016 15:13:20 +0100 log: Fix build failure on openSUSE 42.2 [#2208] The following build failure was fixed: CC logtest-tet_Log_misc.o tet_LogOiOps.c: In function ‘saLogOi_22’: tet_LogOiOps.c:568:2: error: call to function ‘logFinalize’ without a real prototype [-Werror=unprototyped-calls] logFinalize(logHandle); ^ In file included from logtest.h:35:0, from tet_LogOiOps.c:26: ./logutil.h:52:13: note: ‘logFinalize’ was declared here SaAisErrorT logFinalize(); ^ tet_saLogLimitGet.c: In function ‘saLogLimitGet_01’: tet_saLogLimitGet.c:31:2: error: call to function ‘logFinalize’ without a real prototype [-Werror=unprototyped-calls] logFinalize(logHandle); ^ In file included from logtest.h:35:0, from tet_saLogLimitGet.c:18: ./logutil.h:52:13: note: ‘logFinalize’ was declared here SaAisErrorT logFinalize(); ^ cc1: all warnings being treated as errors Makefile:866: recipe for target 'logtest- tet_saLogLimitGet.o' failed make[2]: *** [logtest-tet_saLogLimitGet.o] Error 1 make[2]: *** Waiting for unfinished jobs.... cc1: all warnings being treated as errors Makefile:880: recipe for target 'logtest-tet_LogOiOps.o' failed Complete diffstat: ------------------ tests/logsv/logutil.c | 6 +++--- tests/logsv/logutil.h | 6 +++--- tests/logsv/tet_LogOiOps.c | 2 +- tests/logsv/tet_saLogLimitGet.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) Testing Commands: ----------------- run logtest Testing, Expected Results: -------------------------- All tests should pass Conditions of Submission: ------------------------- Ack from at least two reviewers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
