Hi Anders Widell,
ACK, Not build/tested.
-AVM
On 11/25/2016 7:55 PM, Anders Widell wrote:
> tests/logsv/logutil.c | 6 +++---
> tests/logsv/logutil.h | 6 +++---
> tests/logsv/tet_LogOiOps.c | 2 +-
> tests/logsv/tet_saLogLimitGet.c | 2 +-
> 4 files changed, 8 insertions(+), 8 deletions(-)
>
>
> The following build failure was fixed:
>
> CC logtest-tet_Log_misc.o
> tet_LogOiOps.c: In function ‘saLogOi_22’:
> tet_LogOiOps.c:568:2: error: call to function ‘logFinalize’ without a real
> prototype [-Werror=unprototyped-calls]
> logFinalize(logHandle);
> ^
> In file included from logtest.h:35:0,
> from tet_LogOiOps.c:26:
> ./logutil.h:52:13: note: ‘logFinalize’ was declared here
> SaAisErrorT logFinalize();
> ^
> tet_saLogLimitGet.c: In function ‘saLogLimitGet_01’:
> tet_saLogLimitGet.c:31:2: error: call to function ‘logFinalize’ without a
> real prototype [-Werror=unprototyped-calls]
> logFinalize(logHandle);
> ^
> In file included from logtest.h:35:0,
> from tet_saLogLimitGet.c:18:
> ./logutil.h:52:13: note: ‘logFinalize’ was declared here
> SaAisErrorT logFinalize();
> ^
> cc1: all warnings being treated as errors
> Makefile:866: recipe for target 'logtest-tet_saLogLimitGet.o' failed
> make[2]: *** [logtest-tet_saLogLimitGet.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> cc1: all warnings being treated as errors
> Makefile:880: recipe for target 'logtest-tet_LogOiOps.o' failed
>
> diff --git a/tests/logsv/logutil.c b/tests/logsv/logutil.c
> --- a/tests/logsv/logutil.c
> +++ b/tests/logsv/logutil.c
> @@ -66,7 +66,7 @@ int systemCall(const char *command)
> /*
> * Wrapper function for 'saLogInitialize'
> */
> -SaAisErrorT logInitialize()
> +SaAisErrorT logInitialize(void)
> {
> SaAisErrorT rc = saLogInitialize(&logHandle, &logCallbacks,
> &logVersion);
> unsigned int nTries = 1;
> @@ -82,7 +82,7 @@ SaAisErrorT logInitialize()
> /*
> * Wrapper function for 'saLogFinalize'
> */
> -SaAisErrorT logFinalize()
> +SaAisErrorT logFinalize(void)
> {
> SaAisErrorT rc = saLogFinalize(logHandle);
> unsigned int nTries = 1;
> @@ -152,7 +152,7 @@ SaAisErrorT logWriteAsync(const SaLogRec
> /*
> * Wrapper function for 'saLogStreamClose'
> */
> -SaAisErrorT logStreamClose()
> +SaAisErrorT logStreamClose(void)
> {
> SaAisErrorT rc = saLogStreamClose(logStreamHandle);
> unsigned int nTries = 1;
> diff --git a/tests/logsv/logutil.h b/tests/logsv/logutil.h
> --- a/tests/logsv/logutil.h
> +++ b/tests/logsv/logutil.h
> @@ -48,12 +48,12 @@ const char *hostname(void);
> bool is_test_done_on_pl(void);
> void cond_check(void);
>
> -SaAisErrorT logInitialize();
> -SaAisErrorT logFinalize();
> +SaAisErrorT logInitialize(void);
> +SaAisErrorT logFinalize(void);
> SaAisErrorT logStreamOpen(const SaNameT *logStreamName);
> SaAisErrorT logAppStreamOpen(const SaNameT *logStreamName,
> const SaLogFileCreateAttributesT_2
> *logFileCreateAttributes);
> -SaAisErrorT logStreamClose();
> +SaAisErrorT logStreamClose(void);
> SaAisErrorT logWriteAsync(const SaLogRecordT *logRecord);
>
> #endif /* LOG_UTIL_H_ */
> diff --git a/tests/logsv/tet_LogOiOps.c b/tests/logsv/tet_LogOiOps.c
> --- a/tests/logsv/tet_LogOiOps.c
> +++ b/tests/logsv/tet_LogOiOps.c
> @@ -565,7 +565,7 @@ void saLogOi_22(void)
> rc_validate(WEXITSTATUS(rc), 1);
>
> done:
> - logFinalize(logHandle);
> + logFinalize();
> }
>
> /**
> diff --git a/tests/logsv/tet_saLogLimitGet.c b/tests/logsv/tet_saLogLimitGet.c
> --- a/tests/logsv/tet_saLogLimitGet.c
> +++ b/tests/logsv/tet_saLogLimitGet.c
> @@ -28,7 +28,7 @@ void saLogLimitGet_01(void)
> return;
> }
> rc = saLogLimitGet(logHandle,
> SA_LOG_MAX_NUM_CLUSTER_APP_LOG_STREAMS_ID, &limitValue);
> - logFinalize(logHandle);
> + logFinalize();
> test_validate(rc, SA_AIS_ERR_NOT_SUPPORTED);
> }
>
------------------------------------------------------------------------------
_______________________________________________
Opensaf-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
