Summary: log: implement SaLogFilterSetCallbackT V2 [#2146]
Review request for Trac Ticket(s): #2146
Peer Reviewer(s): Vu, Lennart, Mahesh
Pull request to: Vu
Affected branch(es): default
Development branch: default
--------------------------------
Impacted area Impact y/n
--------------------------------
Docs n
Build system n
RPM/packaging n
Configuration files n
Startup scripts n
SAF services n
OpenSAF services y
Core libraries n
Samples n
Tests n
Other n
Comments (indicate scope for each "y" above):
---------------------------------------------
<<EXPLAIN/COMMENT THE PATCH SERIES HERE>>
changeset b185bb5573f918100ca64e4c69e7d26c55bf5cfc
Author: Canh Van Truong <canh.v.tru...@dektech.com.au>
Date: Mon, 21 Nov 2016 17:19:56 +0700
log: implement SaLogFilterSetCallbackT [#2146]
Implement SaLogFilterSetCallbackT which is mentioned at section 3.6.5
SaLogFilterSetCallbackT @ AIS LOG document.
LGS:
- Whenever severity filter is changed for app and systerm streams,
lgs will
find which clients that associate with the stream. Then lgs sends
message
callback to clients.
- Encoding callback message for severity filter callback
LGA:
- Decoding callback message for severity callback from lgs and
send the
message to the client which setting filter callback.
- Dispatching severity filter callback
- Encrease version of log service to A.02.03
Complete diffstat:
------------------
src/log/agent/lga.h | 3 +
src/log/agent/lga_api.c | 2 +-
src/log/agent/lga_mds.c | 70 +++++++++++++++++++
src/log/agent/lga_util.c | 60 +++++++++++++++-
src/log/apitest/logtest.c | 2 +-
src/log/apitest/logtestfr.c | 2 +-
src/log/apitest/saflogtest.c | 2 +-
src/log/apitest/tet_LogOiOps.c | 71 +++++++++++++++++++
src/log/apitest/tet_log_longDN.c | 2 +-
src/log/apitest/tet_saLogFilterSetCallbackT.c | 364
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
src/log/apitest/tet_saLogStreamOpen_2.c | 2 -
src/log/common/lgsv_defs.h | 2 +-
src/log/common/lgsv_msg.h | 7 +
src/log/logd/lgs_imm.cc | 7 +
src/log/logd/lgs_mds.cc | 57 ++++++++++-----
src/log/logd/lgs_util.cc | 80 +++++++++++++++++++++
src/log/logd/lgs_util.h | 2 +
src/log/tools/saf_logger.c | 2 +-
src/osaf/saflog/saflog.c | 4 +-
19 files changed, 707 insertions(+), 34 deletions(-)
Testing Commands:
-----------------
Create some test cases:
logtest 4 58
logtest 17
Testing, Expected Results:
--------------------------
All test cases pass
Conditions of Submission:
-------------------------
Ack from reviewers
Arch Built Started Linux distro
-------------------------------------------
mips n n
mips64 n n
x86 n n
x86_64 n n
powerpc n n
powerpc64 n n
Reviewer Checklist:
-------------------
[Submitters: make sure that your review doesn't trigger any checkmarks!]
Your checkin has not passed review because (see checked entries):
___ Your RR template is generally incomplete; it has too many blank entries
that need proper data filled in.
___ You have failed to nominate the proper persons for review and push.
___ Your patches do not have proper short+long header
___ You have grammar/spelling in your header that is unacceptable.
___ You have exceeded a sensible line length in your headers/comments/text.
___ You have failed to put in a proper Trac Ticket # into your commits.
___ You have incorrectly put/left internal data in your comments/files
(i.e. internal bug tracking tool IDs, product names etc)
___ You have not given any evidence of testing beyond basic build tests.
Demonstrate some level of runtime or other sanity testing.
___ You have ^M present in some of your files. These have to be removed.
___ You have needlessly changed whitespace or added whitespace crimes
like trailing spaces, or spaces before tabs.
___ You have mixed real technical changes with whitespace and other
cosmetic code cleanup changes. These have to be separate commits.
___ You need to refactor your submission into logical chunks; there is
too much content into a single commit.
___ You have extraneous garbage in your review (merge commits etc)
___ You have giant attachments which should never have been sent;
Instead you should place your content in a public tree to be pulled.
___ You have too many commits attached to an e-mail; resend as threaded
commits, or place in a public tree for a pull.
___ You have resent this content multiple times without a clear indication
of what has changed between each re-send.
___ You have failed to adequately and individually address all of the
comments and change requests that were proposed in the initial review.
___ You have a misconfigured ~/.hgrc file (i.e. username, email etc)
___ Your computer have a badly configured date and time; confusing the
the threaded patch review.
___ Your changes affect IPC mechanism, and you don't present any results
for in-service upgradability test.
___ Your changes affect user manual and documentation, your patch series
do not contain the patch that updates the Doxygen manual.
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel
