Summary: base: Improve TRACE_ENTER, TRACE_LEAVE macros Review request for Trac Ticket(s): [#2262] Peer Reviewer(s): Ramesh, AndersW, Nagu Pull request to: Affected branch(es): default Development branch: default
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- <<EXPLAIN/COMMENT THE PATCH SERIES HERE>> changeset 2e8454d86ef1cf81e1d8ff3a4c439ddb0b8b8967 Author: Hans Nordeback <hans.nordeb...@ericsson.com> Date: Fri, 13 Jan 2017 10:36:37 +0100 base: Improve TRACE_ENTER, TRACE_LEAVE macros [#2262] Complete diffstat: ------------------ src/amf/amfd/ckpt_dec.cc | 2 ++ src/amf/amfd/clm.cc | 2 ++ src/amf/amfd/csi.cc | 7 ++++++- src/amf/amfd/node.cc | 4 +++- src/amf/amfd/nodegroup.cc | 4 +++- src/amf/amfd/si_dep.cc | 1 + src/amf/amfnd/pgdb.cc | 4 ++-- src/amf/amfnd/su.cc | 2 ++ src/base/logtrace.c | 18 +++++++++++++----- src/base/logtrace.h | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ src/imm/agent/imma_init.cc | 7 +++++-- src/imm/agent/imma_om_api.cc | 2 -- src/imm/immnd/ImmModel.cc | 16 ++++++++-------- src/imm/immpbed/immpbe_daemon.cc | 4 +++- src/log/logd/lgs_imm_gcfg.cc | 2 ++ src/log/logd/lgs_main.cc | 2 ++ src/log/logd/lgs_mbcsv.cc | 2 ++ src/ntf/ntfd/NtfClient.cc | 2 +- src/smf/smfd/SmfCampaignXmlParser.cc | 3 +++ src/smf/smfd/SmfUpgradeStep.cc | 3 +++ 20 files changed, 111 insertions(+), 24 deletions(-) Testing Commands: ----------------- <<LIST THE COMMAND LINE TOOLS/STEPS TO TEST YOUR CHANGES>> Testing, Expected Results: -------------------------- <<PASTE COMMAND OUTPUTS / TEST RESULTS>> Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Developer Access Program for Intel Xeon Phi Processors Access to Intel Xeon Phi processor-based developer platforms. With one year of Intel Parallel Studio XE. Training and support from Colfax. Order your platform today. http://sdm.link/xeonphi _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel