Summary: amf: add support for restrictions to auto-repair Review request for Trac Ticket(s): 2144 Peer Reviewer(s): praveen Pull request to: Affected branch(es): default Development branch:
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- This patch should be applied on top of the previous one sent. It is necessary because SMF will only issue AMF node lock and lock-in when upgrading or rolling back a node before rebooting. When the node reboots AMF cannot set disabled state for the SUs, or SMF will think there is a problem. Also, Section 3.2.6.2 of the AMF spec states that "If a node is enabled and in the locked-instantiation administrative state when it leaves the cluster membership, the node stays enabled until it joins the cluster again." I do not think this strictly means CLM node admin, because the SMF spec only talks about AMF node admin, and it expects this behavior. changeset 0b7d937a14c18ff5ead9eadc55733e5b782be66e Author: Alex Jones <[email protected]> Date: Fri, 24 Feb 2017 16:06:19 -0500 amf: add support for restrictions to auto-repair [#2144] This patch adds support for Section 3.11.1.4.2 of AMF B.04.01 spec: Restrictions to Auto-Repair. Complete diffstat: ------------------ src/amf/amfd/ndproc.cc | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) Testing Commands: ----------------- (1) amf-adm lock <amf node> (2) amf-adm lock-in <amf node> (3) reboot that amf node Testing, Expected Results: -------------------------- (1) active amfd should not declare the amf node disabled nor any of its SUs or comps Conditions of Submission: ------------------------- <<HOW MANY DAYS BEFORE PUSHING, CONSENSUS ETC>> Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
