Hi Praveen, Pushing the acked patch w/out this extra fix would break SMF rollback and Undo for a node that needs to be rebooted as part of the upgrade.
So, we either need to work on this issue now, or postpone the ticket
for the next release.
Alex
On 02/27/2017 08:33 AM, praveen malviya wrote:
> ------------------------------------------------------------------------
> NOTICE: This email was received from an EXTERNAL sender
> ------------------------------------------------------------------------
>
> Hi Alex,
>
> Please push acked patch of #2144 by tomorrow as it is in the list of
> pending tickets for FC tag.
>
> This issue can be pushed post FC in a separate patch once the patch gets
> finalized.
>
> Thanks,
> Praveen
>
>
> On 27-Feb-17 12:25 PM, praveen malviya wrote:
>> Hi Alex,
>>
>> Please find some comments inline with [Praveen].
>>
>> Thanks,
>> Praveen
>>
>> On 25-Feb-17 2:44 AM, Alex Jones wrote:
>>> src/amf/amfd/ndproc.cc | 6 ++++--
>>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>>
>>>
>>> This patch adds support for Section 3.11.1.4.2 of AMF B.04.01 spec:
> Restrictions
>>> to Auto-Repair.
>>>
>>> diff --git a/src/amf/amfd/ndproc.cc b/src/amf/amfd/ndproc.cc
>>> --- a/src/amf/amfd/ndproc.cc
>>> +++ b/src/amf/amfd/ndproc.cc
>>> @@ -1140,8 +1140,10 @@ void avd_node_failover(AVD_AVND *node)
>>> TRACE_ENTER2("'%s'", node->name.c_str());
>>> avd_node_mark_absent(node);
>>> avd_pg_node_csi_del_all(avd_cb, node);
>>> - avd_node_down_mw_susi_failover(avd_cb, node);
>>> - avd_node_down_appl_susi_failover(avd_cb, node);
>>> + if (node->saAmfNodeAdminState != SA_AMF_ADMIN_LOCKED_INSTANTIATION) {
>>> + avd_node_down_mw_susi_failover(avd_cb, node);
>> [Praveen] Since node is in LOCK_IN state there are not application
>> running on it, but failover of middle ware components still needs to be
>> done.
>> One more thing, as per spec AMF has to mark a node disabled when it
>> reboots. Since avd_node_failover() is called in both the cases a)when a
>> node is rebooted in controlled way and b)when a node reboots because of
>> failure of any director component. So this differentiation is still
> needed.
>> Thanks,
>> Praveen
>>> + avd_node_down_appl_susi_failover(avd_cb, node);
>>> + }
>>> avd_node_delete_nodeid(node);
>>> TRACE_LEAVE();
>>> }
>>>
>>
>>
> ------------------------------------------------------------------------------
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> _______________________________________________
>> Opensaf-devel mailing list
>> [email protected]
> <mailto:[email protected]>
>> https://lists.sourceforge.net/lists/listinfo/opensaf-devel
>>
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
