Summary: smfd: add support for asynchronous detection of failed AMF entities Review request for Trac Ticket(s): 2145 Peer Reviewer(s): Neel, Lennart, Rafael Pull request to: Affected branch(es): default Development branch:
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- This patch should replace the previously submitted one. It needs to be used in conjunction with the AMF patch for 2144 acked by Praveen (with some changes afterwards). This patch has been rebased to work with the new directory structure. And, the asyncFailure state machine has been refactored a little bit. changeset fabc71867922d9304c9d0ed1c64af61ef72d77d5 Author: Alex Jones <[email protected]> Date: Tue, 28 Feb 2017 21:06:21 -0500 smfd: add support for asynchronous detection of failed AMF entities [#2145] This patch adds support for section 4.2.1.3 of SMF A.01.02 spec. Complete diffstat: ------------------ src/smf/smfd/SmfCampState.cc | 68 ++++++++++++++++++++++++++++++++ src/smf/smfd/SmfCampState.h | 7 +++ src/smf/smfd/SmfCampaignThread.cc | 233 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- src/smf/smfd/SmfCampaignThread.h | 15 +++++++ src/smf/smfd/SmfStepTypes.cc | 32 ++++++++------ src/smf/smfd/SmfUpgradeCampaign.cc | 20 +++++++++ src/smf/smfd/SmfUpgradeCampaign.h | 7 +++ 7 files changed, 363 insertions(+), 19 deletions(-) Testing Commands: ----------------- (1) try some different upgrade campaigns and admin operations, and kill some comps that are part of the upgrade campaign after the upgrade has started Testing, Expected Results: -------------------------- (1) any comp which has been killed, and that has its suMaintenance attribute set, should show up in the campaign error attribute (2) if the campaign is in Executing, RollingBack, or SuspendingExecution, the campaign should transition to an error state according to the spec (3) if the campaign is not in one of these three states, the error attribute should still show the failed SU, but there should be no state transition according to the spec Conditions of Submission: ------------------------- Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, SlashDot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
