Summary: dtm: Convert DTM to C++ [#2553] Review request for Ticket(s): 2553 Peer Reviewer(s): Mahesh, Alex Pull request to: Affected branch(es): develop Development branch: ticket-2553 Base revision: 2b4b4b2fd0f70381832ffff093dd09d4a75208c0 Personal repository: git://git.code.sf.net/u/anders-w/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services y Core libraries n Samples n Tests n Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- revision 46e8295a92c66e9753de7a5475aed7f5534bab79 Author: Anders Widell <[email protected]> Date: Tue, 22 Aug 2017 15:57:11 +0200 dtm: Re-indent DTM after conversion to C++ [#2553] Re-indent the DTM code according to the Google C++ style guide. Whitespace change only. revision aaf267000e847899f907814433a22b96f4afb0d8 Author: Anders Widell <[email protected]> Date: Tue, 22 Aug 2017 15:52:33 +0200 dtm: Convert DTM to C++ [#2553] Convert DTM source files to C++, and perform some simple refactoring steps: * 0 -> nullptr * old style cast -> new style cast Complete diffstat: ------------------ src/dtm/Makefile.am | 24 +- src/dtm/dtmnd/dtm.h | 21 +- src/dtm/dtmnd/dtm_cb.h | 12 +- src/dtm/dtmnd/dtm_inter.h | 18 +- src/dtm/dtmnd/dtm_inter_disc.h | 10 +- src/dtm/dtmnd/dtm_inter_svc.c | 535 -------- src/dtm/dtmnd/dtm_inter_svc.cc | 522 ++++++++ src/dtm/dtmnd/dtm_inter_trans.c | 368 ------ src/dtm/dtmnd/dtm_inter_trans.cc | 357 ++++++ src/dtm/dtmnd/dtm_inter_trans.h | 2 +- src/dtm/dtmnd/dtm_intra.c | 1125 ----------------- src/dtm/dtmnd/dtm_intra.cc | 1005 ++++++++++++++++ src/dtm/dtmnd/dtm_intra.h | 17 +- src/dtm/dtmnd/dtm_intra_disc.h | 29 +- src/dtm/dtmnd/dtm_intra_svc.c | 2411 ------------------------------------- src/dtm/dtmnd/dtm_intra_svc.cc | 2111 ++++++++++++++++++++++++++++++++ src/dtm/dtmnd/dtm_intra_trans.c | 280 ----- src/dtm/dtmnd/dtm_intra_trans.cc | 269 +++++ src/dtm/dtmnd/dtm_intra_trans.h | 4 + src/dtm/dtmnd/dtm_main.c | 430 ------- src/dtm/dtmnd/dtm_main.cc | 401 ++++++ src/dtm/dtmnd/dtm_node.c | 682 ----------- src/dtm/dtmnd/dtm_node.cc | 622 ++++++++++ src/dtm/dtmnd/dtm_node.h | 8 +- src/dtm/dtmnd/dtm_node_db.c | 315 ----- src/dtm/dtmnd/dtm_node_db.cc | 293 +++++ src/dtm/dtmnd/dtm_node_sockets.c | 1587 ------------------------ src/dtm/dtmnd/dtm_node_sockets.cc | 1461 ++++++++++++++++++++++ src/dtm/dtmnd/dtm_read_config.c | 672 ----------- src/dtm/dtmnd/dtm_read_config.cc | 592 +++++++++ src/dtm/dtmnd/dtm_socket.h | 3 + 31 files changed, 7717 insertions(+), 8469 deletions(-) Testing Commands: ----------------- Run regression tests with OpenSAF configured to use TCP transport. Testing, Expected Results: -------------------------- Regression tests shall pass. Conditions of Submission: ------------------------- Ack from reviewer(s). Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
