Summary: msg: don't create cache entry if operation is delete [#2619] Review request for Ticket(s): 2619 Peer Reviewer(s): AVM Pull request to: Affected branch(es): develop Development branch: ticket-2619 Base revision: 44d113c4fa669065afe78d70bc81c5297d79ec0e Personal repository: git://git.code.sf.net/u/trguitar/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- revision 4893fb7f33788e288f0061e38437ea358f88e4c5 Author: Alex Jones <[email protected]> Date: Fri, 6 Oct 2017 09:24:09 -0400 msg: don't create cache entry if operation is delete [#2619] saMsgMessageSend and Async calls return TRY_AGAIN forever after controller failover. If more than 1 ASAPi_MSG_TRACK_NTFY for deletion is processed by the cache, the first time the cache entry will be deleted. When the second one comes in, before a new queue registration message has been received, the cache entry will be created with bad information, even though this is a delete operation. Don't create cache entries for delete operations. Complete diffstat: ------------------ src/msg/common/mqsv_asapi.c | 5 +++++ 1 file changed, 5 insertions(+) Testing Commands: ----------------- 1) create a msg q on the active controller 2) from another node write to that msg q every few milliseconds 3) reboot the active controller 4) reopen the msg q on the newly active controller Testing, Expected Results: -------------------------- 1) writes to the msg q should not get TRY_AGAIN forever Conditions of Submission: ------------------------- Ack from AVM, or on Oct 16 Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
