Hi Alex, Please find my comments below, preceded with [Srinivas].
Thank you Srinivas -----Original Message----- From: Alex Jones [mailto:[email protected]] Sent: Friday, October 6, 2017 7:05 PM To: Venkata Mahesh Alla <[email protected]> Cc: Alex Jones <[email protected]>; [email protected] Subject: [devel] [PATCH 1/1] msg: don't create cache entry if operation is delete [#2619] saMsgMessageSend and Async calls return TRY_AGAIN forever after controller failover. If more than 1 ASAPi_MSG_TRACK_NTFY for deletion is processed by the cache, the first time the cache entry will be deleted. When the second one comes in, before a new queue registration message has been received, the cache entry will be created with bad information, even though this is a delete operation. Don't create cache entries for delete operations. --- src/msg/common/mqsv_asapi.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/msg/common/mqsv_asapi.c b/src/msg/common/mqsv_asapi.c index f39d564..8b6fb65 100644 --- a/src/msg/common/mqsv_asapi.c +++ b/src/msg/common/mqsv_asapi.c @@ -649,6 +649,11 @@ static uint32_t asapi_cache_update(ASAPi_OBJECT_INFO *pInfo, m_NCS_UNLOCK(&pCache->clock, NCS_LOCK_WRITE); /* Unlock the cache */ } else { /* Node deosn't exist */ + if (ASAPi_QUEUE_DEL == opr || ASAPi_GROUP_DEL) { [Srinivas] : This "if" condition seems to be wrong. ASAPi_GROUP_DEL is a part of an enum and has value greater then 0, so this "if" condition will always be satisfied and we will "return" from this function for all the operations. + /* no need to add node as this is a deletion */ + return rc; + } + /* Allocate the Cache Informaton node */ pCache = m_MMGR_ALLOC_ASAPi_CACHE_INFO(asapi.my_svc_id); if (!pCache) { -- 2.9.5 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! https://urldefense.proofpoint.com/v2/url?u=http-3A__sdm.link_slashdot&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=JfwZbiSY19b5J19rDeSKt00rK2wWHkoCYtw6qH4qSnU&m=hA9_X6k30fxk8ZhhUvIBq3eYbnDEDcT6yvcyVss_lX8&s=axIea0t0xuGp13RJxO4UCTjoD3AN2PHXVspSuQC2wPc&e= _______________________________________________ Opensaf-devel mailing list [email protected] https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.sourceforge.net_lists_listinfo_opensaf-2Ddevel&d=DwICAg&c=RoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=JfwZbiSY19b5J19rDeSKt00rK2wWHkoCYtw6qH4qSnU&m=hA9_X6k30fxk8ZhhUvIBq3eYbnDEDcT6yvcyVss_lX8&s=cOK_XAThgRORQFin1lLX_gkIEKcVtzixVLBXn4OxX9E&e= ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
