Hi, Reviewed and tested the patch. Ack from me with minor comment.
When OpenSAF is started the second time, it exits with "*". It would be good to write some text why OpenSAF didn't succeed to start, as it was a case with Hans's patch earlier. Thanks, Zoran -----Original Message----- From: Rafael Odzakow Sent: den 10 oktober 2017 14:08 To: Zoran Milinkovic <[email protected]>; Hans Nordebäck <[email protected]> Cc: [email protected]; Rafael Odzakow <[email protected]> Subject: [PATCH 1/1] base: double start failed [#2622] Previously named function "check_env" overwrites pid file. Move it to after running pidofproc for amfnd pid. --- src/nid/opensafd.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/nid/opensafd.in b/src/nid/opensafd.in index effe87d..d7035f5 100644 --- a/src/nid/opensafd.in +++ b/src/nid/opensafd.in @@ -235,8 +235,6 @@ mutex_remove() { } start() { - setup_env - if ! mutex_create; then return 1 fi @@ -254,6 +252,8 @@ start() { [ -x $daemon ] || exit 5 + setup_env + check_transport logger -t $osafprog "Starting OpenSAF Services($osafversion - $osafcshash) (Using $MDS_TRANSPORT)" -- 2.7.4 ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
