Hi Rafael,

not tested, minor comment/question below.

Regards /Hans



On 10/10/2017 02:08 PM, Rafael Odzakow wrote:
Previously named function "check_env" overwrites pid file. Move it to
after running pidofproc for amfnd pid.
---
  src/nid/opensafd.in | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/nid/opensafd.in b/src/nid/opensafd.in
index effe87d..d7035f5 100644
--- a/src/nid/opensafd.in
+++ b/src/nid/opensafd.in
@@ -235,8 +235,6 @@ mutex_remove() {
  }
start() {
-       setup_env
-
        if ! mutex_create; then
                return 1
        fi
@@ -254,6 +252,8 @@ start() {
[HansN] , not in the patch, but put double quote around the
[ -x "$daemon" ] || exit 5

I guess if putting double quote this check if $daemon exists/is executable returns correct value but not if the check is done without the double quote. Where is the variable daemon set? It seems it is set in lsb function status_of_proc (Ubuntu14) but
that function is not called in opensafd.in
        [ -x $daemon ] || exit 5
+ setup_env
+
        check_transport
logger -t $osafprog "Starting OpenSAF Services($osafversion - $osafcshash) (Using $MDS_TRANSPORT)"


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Opensaf-devel mailing list
Opensaf-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensaf-devel

Reply via email to