Ack with the comment that I think you should keep the pkill -STOP commands.


Anders Widell

On 04/16/2018 11:41 AM, Ravi Sekhar Reddy Konda wrote:
HI Anders,

In the opensaf_reboot script we added these commands as safe mechanism,  so 
that we won't see issues like AMF taking Active role and start assigning. But 
as  part of this patch we are bringing down the communication mechanism, prior 
to killing these core saf services. So  I thought there is no need to bring 
them again.  Also if applications are using different communication mechanism 
we are recommending user to isolate applications  prior to bringing down tipc 
or dtm in the opensaf_reboot.

Still I don't see any issue in having those commands also in the 
opensaf_reboot, I can retain them as safe mechanism.


-----Original Message-----
From: Anders Widell [mailto:anders.wid...@ericsson.com]
Sent: Friday, April 13, 2018 5:18 PM
To: ravi-sekhar <ravisekhar.ko...@oracle.com>; hans.nordeb...@ericsson.com
Cc: opensaf-devel@lists.sourceforge.net
Subject: Re: [PATCH 1/1] osaf: Isolate the node in the opensaf_reboot [#2833]

A question: why did you remove the "pkill -STOP osafamfwd" etc commands?


Anders Widell

On 04/12/2018 03:29 PM, ravi-sekhar wrote:
   scripts/opensaf_reboot | 19 +++++++++++++------
   1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/scripts/opensaf_reboot b/scripts/opensaf_reboot index
df65c26..b219c39 100644
--- a/scripts/opensaf_reboot
+++ b/scripts/opensaf_reboot
@@ -37,6 +37,9 @@ export LD_LIBRARY_PATH=$libdir:$LD_LIBRARY_PATH
   if [ -f "$pkgsysconfdir/fmd.conf" ]; then
     . "$pkgsysconfdir/fmd.conf"
+if [ -f "$pkgsysconfdir/nid.conf" ]; then
+  . "$pkgsysconfdir/nid.conf"
NODE_ID_FILE=$pkglocalstatedir/node_id @@ -118,7 +121,17 @@ else
                # uncomment the following line if debugging errors that keep 
restarting the node
                # exit 0
+ # If the application is using different interface for cluster communication, please
+                # add your application specific isolation commands
+ here
                logger -t "opensaf_reboot" "Rebooting local node; 
+                # Isolate the node
+                if [ "$MDS_TRANSPORT" = "TIPC" ]; then
+                   tipc-config -bd eth:$TIPC_ETH_IF
+                else
+                   $icmd pkill -STOP osafdtmd
+                fi
# Start a reboot supervision background process. Note that a similar
                # supervision is also done in the opensaf_reboot() function in 
@@ -128,12 +141,6 @@ else
                        (sleep "$OPENSAF_REBOOT_TIMEOUT"; echo -n "b" > 
"/proc/sysrq-trigger") &
- # Stop some important opensaf processes to prevent bad things from happening
-               $icmd pkill -STOP osafamfwd
-               $icmd pkill -STOP osafamfnd
-               $icmd pkill -STOP osafamfd
-               $icmd pkill -STOP osaffmd
                # Flush OpenSAF internal log server messages to disk.
                $bindir/osaflog --flush

Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Opensaf-devel mailing list

Reply via email to