Hi Nagu and Hans, When I was testing the patch for #2929, and found that the issue in #2926 should also be fixed in #2929 too.
Sorry I should have informed you earlier, I'm still testing #2929. Please ignore the patch in #2926. Thanks Minh On 25/09/18 15:55, Nagendra Kumar wrote: > Hi Minh, >>> With frist patch: PL3 reboot >>> With second patch: SU's assignment on PL3 is gracefully removed > So, which patch you want to push? > > Thanks > -Nagu > > -----Original Message----- > From: Minh Chau [mailto:minh.c...@dektech.com.au] > Sent: 19 September 2018 04:20 > To: hans.nordeb...@ericsson.com; nagen...@hasolutions.in; > gary....@dektech.com.au > Cc: opensaf-devel@lists.sourceforge.net; Minh Chau > Subject: [PATCH 0/2] Review Request for amfd: Split-brain recovery for > NwayActive [#2926] > > Summary: amfd: Reboot the node that has SU over-assigned after split brain > [#2926] > Review request for Ticket(s): 2926 > Peer Reviewer(s): *** Hans, Gary, Nagu > Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** > Affected branch(es): develop > Development branch: ticket-2926 > Base revision: 6f4f5ddc776a7e566b6958ecd4d4a3502bccfa5e > Personal repository: git://git.code.sf.net/u/minh-chau/review > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** > > revision fba567eb3bb5fd4dfcd73a2c950b60242cd60e4a > Author: Minh Chau <minh.c...@dektech.com.au> > Date: Wed, 19 Sep 2018 08:11:56 +1000 > > amfd: Remove assignment of NwayActive SU which is over assigned after split > brain [#2926] > > > > revision 626d18262a67bb73aeed713ee6037b5ba030f736 > Author: Minh Chau <minh.c...@dektech.com.au> > Date: Wed, 19 Sep 2018 08:11:17 +1000 > > amfd: Reboot the node that has SU over-assigned after split brain [#2926] > > After split-brain, the assignments can go over the preferred number. > Reboot the node once at time until the current active assignments > is equal to preferred number. > > > > Complete diffstat: > ------------------ > src/amf/amfd/sg_nwayact_fsm.cc | 18 +++++++++++++++--- > src/amf/amfd/siass.cc | 5 ++++- > 2 files changed, 19 insertions(+), 4 deletions(-) > > > Testing Commands: > ----------------- > Deploy NwayActive with preferred_active = 2 > PL3 and PL4 has active assignment > Execute the test that trigger split brain with two partition. > [SC-1, PL5] [SC2, PL3, PL4] > Merge two partitions > Restart SC > > Testing, Expected Results: > -------------------------- > With frist patch: PL3 reboot > With second patch: SU's assignment on PL3 is gracefully removed > > > Conditions of Submission: > ------------------------- > ack from reviewers > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 y y > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email > etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > > > _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
