Hi Hans, polite reminder for review. Thanks Mohan High Availability Solutions Pvt. Ltd. www.hasolutions.in
--------- Original Message --------- Subject: RE: [PATCH 0/5] Review Request for clm: add new test cases in clm apitest [#2914] From: [email protected] Date: 11/15/18 5:36 pm To: [email protected], [email protected], [email protected] Cc: [email protected], "Mohan Kanakam" <[email protected]> Hi Hans, polite reminder for review. Thanks Mohan High Availability Solutions Pvt. Ltd. www.hasolutions.in --------- Original Message --------- Subject: [PATCH 0/5] Review Request for clm: add new test cases in clm apitest [#2914] From: "Mohan Kanakam" <[email protected]> Date: 11/6/18 1:23 pm To: [email protected], [email protected], [email protected] Cc: [email protected], "Mohan Kanakam" <[email protected]> Summary: clm: add new test case of API saClmInitialize() of apitest [#2914] Review request for Ticket(s): 2914 Peer Reviewer(s):Anders, Hans, Ravi Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop Development branch: ticket-2914 Base revision: f8a6848a1cdbff0b518c3db951e4689e260226c7 Personal repository: git://git.code.sf.net/u/mohan-hasoln/review -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services n OpenSAF services n Core libraries n Samples n Tests y Other n NOTE: Patch(es) contain lines longer than 80 characers Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision 7b500ebca4037bcf3d55a2112b7aa6cb31a1ac87 Author: Mohan Kanakam <[email protected]> Date: Tue, 6 Nov 2018 13:15:53 +0530 clm: add new test case of API saClmClusterTrackStop() of apitest [#2914] revision 5265697c88e2821157b301dc26b064c9fa59480d Author: Mohan Kanakam <[email protected]> Date: Tue, 6 Nov 2018 12:58:35 +0530 clm: add new test case of API saClmFinalize() of apitest [#2914] revision 6201fde1f0528bfabc0fc999a056b4d97a3b88a8 Author: Mohan Kanakam <[email protected]> Date: Tue, 6 Nov 2018 12:54:04 +0530 clm: add new test case of API saClmDispatch() of apitest [#2914] revision bd8b29be410502c4b579e391a1cb416c8cc3222a Author: Mohan Kanakam <[email protected]> Date: Tue, 6 Nov 2018 12:22:51 +0530 clm: add new test case of API saClmSelectionObjectGet() of apitest [#2914] revision 0202f49f5fff8601d86293c66e7bd816a1e556b8 Author: Mohan Kanakam <[email protected]> Date: Tue, 6 Nov 2018 12:15:27 +0530 clm: add new test case of API saClmInitialize() of apitest [#2914] Complete diffstat: ------------------ src/clm/apitest/tet_saClmClusterTrackStop.cc | 21 +++++ src/clm/apitest/tet_saClmDispatch.cc | 110 +++++++++++++++++++++++++ src/clm/apitest/tet_saClmFinalize.cc | 6 ++ src/clm/apitest/tet_saClmInitialize.cc | 53 ++++++++++++ src/clm/apitest/tet_saClmSelectionObjectGet.cc | 9 ++ 5 files changed, 199 insertions(+) Testing Commands: ----------------- ./clmtest Testing, Expected Results: -------------------------- 13 PASSED saClmInitialize with multiple instance 14 PASSED saClmInitialize_4 with clusterNodeGetCallback as null 15 PASSED saClmInitialize_4 with all parameters as null 16 PASSED saClmInitialize_4 with callback & version as null 17 PASSED saClmInitialize_4 with handle & version as null 18 PASSED saClmInitialize_4 with handle as null 19 PASSED saClmInitialize_4 with handle & ClusterNodeGetCallback as null 5 PASSED saClmSelectionObjectGet Fianlize Handle SA_AIS_ERR_BAD_HANDLE 5 PASSED saClmDispatch - invalid handle SA_DISPATCH_ONE SA_AIS_ERR_BAD_HANDLE 6 PASSED saClmDispatch - invalid handle SA_DISPATCH_BLOCKING SA_AIS_ERR_BAD_HANDLE 7 PASSED saClmDispatch - uninitilized handle SA_DISPATCH_ALL SA_AIS_ERR_BAD_HANDLE 8 PASSED saClmDispatch - uninitilized handle SA_DISPATCH_ONE SA_AIS_ERR_BAD_HANDLE 9 PASSED saClmDispatch - uninitilzed handle SA_DISPATCH_BLOCKING SA_AIS_ERR_BAD_HANDLE 10 PASSED saClmDispatch - finalized handle SA_DISPATCH_ALL SA_AIS_ERR_BAD_HANDLE 11 PASSED saClmDispatch - finalized handle SA_DISPATCH_ONE SA_AIS_ERR_BAD_HANDLE 12 PASSED saClmDispatch - finalized handle SA_DISPATCH_BLOCKING SA_AIS_ERR_BAD_HANDLE 9 PASSED saClmFinalize SA_AIS_ERR_BAD_HANDLE - uninitilzed handle 3 PASSED saClmClusterTrackStop with finalized handle, SA_AIS_ERR_BAD_HANDLE Conditions of Submission: ------------------------- Ack from maintainers Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
