Summary: clmd: send PLM response if node down detected [#2998] (untested) Review request for Ticket(s): 2998 Peer Reviewer(s): Mathi, Hans Pull request to: Affected branch(es): develop Development branch: ticket-2998 Base revision: 5f7408cc86bbbd7cbaa6f94f9ed83fe70c713a16 Personal repository: git://git.code.sf.net/u/trguitar/review
-------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n NOTE: Patch(es) are UNTESTED Comments (indicate scope for each "y" above): --------------------------------------------- *** EXPLAIN/COMMENT THE PATCH SERIES HERE *** revision f06c53f3c3f42e02ba39fe9fa5ac2fa0f92ccaf2 Author: Alex Jones <[email protected]> Date: Tue, 15 Jan 2019 12:09:31 -0500 clmd: send PLM response if node down detected [#2998] PLM HE/EE lock never transitions to LOCKED state if node crashes on which the PLM lock is being done. If a LOCK admin command from PLM is issued on a HE or EE, CLM sends a tracking request to AMF to validate and start the shutdown. When the START track is sent CLM waits for a response from AMF. Because the request is coming from PLM, the time supervision is set to UNKNOWN, which means the response has no time limit. If the node crashes before AMF responds to CLM, the PLM never gets a response from CLM and doesn't transition the HE/EE to locked state. CLM needs to send a response to PLM if it detects node down and there is a pending PLM operation on that node. Complete diffstat: ------------------ src/clm/clmd/clms_evt.cc | 13 +++++++++++++ 1 file changed, 13 insertions(+) Testing Commands: ----------------- 1) Lock a PLM-HE object. 2) Before AMF on that CLM node has responded to CLM, crash that CLM node. Testing, Expected Results: -------------------------- 1) CLM should respond to PLM readiness response with error. Conditions of Submission: ------------------------- Jan 21 or ack from developer Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 y y powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. ----------------------------------------------------------------------------------------------------------------------- Notice: This e-mail together with any attachments may contain information of Ribbon Communications Inc. that is confidential and/or proprietary for the sole use of the intended recipient. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies, including any attachments. ----------------------------------------------------------------------------------------------------------------------- _______________________________________________ Opensaf-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensaf-devel
