Hi Canh, Ack
Thanks Lennart From: Canh Van Truong <canh.v.tru...@dektech.com.au> Sent: den 23 januari 2019 07:13 To: Lennart Lund <lennart.l...@ericsson.com>; Minh Hon Chau <minh.c...@dektech.com.au> Cc: opensaf-devel@lists.sourceforge.net Subject: RE: Review request ntf: update document for limit of logger buffer [#2994] Thanks Lennart I have updated your comments. If no more comments, the document will be pushed. Regards Canh From: Lennart Lund <lennart.l...@ericsson.com<mailto:lennart.l...@ericsson.com>> Sent: Friday, January 18, 2019 3:32 PM To: Canh Van Truong <canh.v.tru...@dektech.com.au<mailto:canh.v.tru...@dektech.com.au>>; Minh Hon Chau <minh.c...@dektech.com.au<mailto:minh.c...@dektech.com.au>> Cc: opensaf-devel@lists.sourceforge.net<mailto:opensaf-devel@lists.sourceforge.net>; Lennart Lund <lennart.l...@ericsson.com<mailto:lennart.l...@ericsson.com>> Subject: RE: Review request ntf: update document for limit of logger buffer [#2994] Hi Canh, Ack, with some minor editorial comments given in the copied text below. See comments within [ ]. Text within { } should be removed and replaced by the text in the following [ ] Text copied from the document with comments: ------------------------------------------ Alarm notification log buffer size. Valid values are 10 to 5000 stored notifications. {Some alarm}[All] notifications are logged using the OpenSAF log service. NTF has a buffer to store alarm notifications to be logged later in case the log service returns TRY AGAIN when NTF writes the log record. When the log service is available again (returns OK) all alarm notifications in the buffer will be written before the NTF service can service any new alarm notification-send requests [incorrect usage of -. Suggest; alarm notification send-requests]. If the buffer is big this may take some time and may cause the requests of NTF client {is}[to] time out. If the buffer is full, NTF will return TRY AGAIN when alarm notification-send request [see previous comment about -] is called. {The sending}[Send] requests of other type[s] [of] notifications are handled normally. Thanks Lennart From: Canh Van Truong <canh.v.tru...@dektech.com.au<mailto:canh.v.tru...@dektech.com.au>> Sent: den 18 januari 2019 08:43 To: Minh Hon Chau <minh.c...@dektech.com.au<mailto:minh.c...@dektech.com.au>>; Lennart Lund <lennart.l...@ericsson.com<mailto:lennart.l...@ericsson.com>> Cc: opensaf-devel@lists.sourceforge.net<mailto:opensaf-devel@lists.sourceforge.net> Subject: RE: Review request ntf: update document for limit of logger buffer [#2994] Hi aMinh I have updated your comments. Please help check and push the document if there are no more comments. Thanks Canh From: Minh Hon Chau <minh.c...@dektech.com.au<mailto:minh.c...@dektech.com.au>> Sent: Friday, January 18, 2019 7:25 AM To: Lennart Lund <lennart.l...@ericsson.com<mailto:lennart.l...@ericsson.com>>; Canh Van Truong <canh.v.tru...@dektech.com.au<mailto:canh.v.tru...@dektech.com.au>> Cc: opensaf-devel@lists.sourceforge.net<mailto:opensaf-devel@lists.sourceforge.net> Subject: Re: Review request ntf: update document for limit of logger buffer [#2994] Hi Canh, A very minor comment, that we may have to mention it's for alarm notif only. Thanks, Minh On 11/1/19 11:30 pm, Lennart Lund wrote: Hi Canh, I should have Acked the document in my previous answer. Just fix any minor things and push. Thanks Lennart From: Canh Van Truong <canh.v.tru...@dektech.com.au><mailto:canh.v.tru...@dektech.com.au> Sent: den 11 januari 2019 12:01 To: Lennart Lund <lennart.l...@ericsson.com><mailto:lennart.l...@ericsson.com>; Minh Hon Chau <minh.c...@dektech.com.au><mailto:minh.c...@dektech.com.au> Cc: opensaf-devel@lists.sourceforge.net<mailto:opensaf-devel@lists.sourceforge.net> Subject: RE: Review request ntf: update document for limit of logger buffer [#2994] Hi Lennart Yes, I add new column for "Default value". Regards Canh From: Lennart Lund <lennart.l...@ericsson.com><mailto:lennart.l...@ericsson.com> Sent: Friday, January 11, 2019 5:33 PM To: Canh Van Truong <canh.v.tru...@dektech.com.au><mailto:canh.v.tru...@dektech.com.au>; Minh Hon Chau <minh.c...@dektech.com.au><mailto:minh.c...@dektech.com.au> Cc: opensaf-devel@lists.sourceforge.net<mailto:opensaf-devel@lists.sourceforge.net> Subject: RE: Review request ntf: update document for limit of logger buffer [#2994] Hi Canh, I have one minor comment in the attached document. Also, it may be better if the table has three columns "Environment Variable, Default value and Comment" Thanks Lennart From: Canh Van Truong <canh.v.tru...@dektech.com.au<mailto:canh.v.tru...@dektech.com.au>> Sent: den 11 januari 2019 10:18 To: Lennart Lund <lennart.l...@ericsson.com<mailto:lennart.l...@ericsson.com>>; Minh Hon Chau <minh.c...@dektech.com.au<mailto:minh.c...@dektech.com.au>> Cc: opensaf-devel@lists.sourceforge.net<mailto:opensaf-devel@lists.sourceforge.net> Subject: RE: Review request ntf: update document for limit of logger buffer [#2994] Thanks Lennart, I have updated with your comments. Please give the comments if there is something need to be updated. Regards Canh From: Lennart Lund <lennart.l...@ericsson.com<mailto:lennart.l...@ericsson.com>> Sent: Thursday, January 10, 2019 9:07 PM To: Canh Van Truong <canh.v.tru...@dektech.com.au<mailto:canh.v.tru...@dektech.com.au>>; Minh Hon Chau <minh.c...@dektech.com.au<mailto:minh.c...@dektech.com.au>> Cc: opensaf-devel@lists.sourceforge.net<mailto:opensaf-devel@lists.sourceforge.net> Subject: RE: Review request ntf: update document for limit of logger buffer [#2994] Hi Canh, The following text describing the NTFSV_LOGGER_BUFFER_CAPACITY environment variable should be improved/simplified (hard to understand) Original text from document: "The limit of logger buffer size in NTFD. The logger buffer is used to store the notification if writing notification to log file fail. The limit should be set with relevant value to avoid congestion in NTFD. Because if this value is set too big while writing notification is fail for long time, NTFD has to write a big number of notifications whenever handling sending notification request and that will delay to handle other requests come to NTFD. The value of variable is from 10 to 5000." Suggestion: Note: my native language is not English so I suggest that this text is checked by someone who knows English better than I do. However, the following information is what I think is needed. "Notification log buffer size. Valid values are 10 to 5000 stored notifications. Default is 10. Some notifications are logged using the OpenSAF log service. NTF has a buffer to store notifications to be logged later in case the log service returns TRY AGAIN (may happen if the log service is temporary unavailable) when NTF writes the log record. When the log service is available again (returns OK) all notifications in the buffer will be written before the NTF service can service any new notification requests. If the buffer is big this may take some time and may cause the NTF client to timeout. If the buffer is full and the log service answers TRY AGAIN NTF will return TRY AGAIN when Notification send is called." Thanks Lennart From: Canh Van Truong <canh.v.tru...@dektech.com.au<mailto:canh.v.tru...@dektech.com.au>> Sent: den 10 januari 2019 12:52 To: Minh Hon Chau <minh.c...@dektech.com.au<mailto:minh.c...@dektech.com.au>>; Lennart Lund <lennart.l...@ericsson.com<mailto:lennart.l...@ericsson.com>> Cc: opensaf-devel@lists.sourceforge.net<mailto:opensaf-devel@lists.sourceforge.net> Subject: Review request ntf: update document for limit of logger buffer [#2994] Update the document because of the ticket #2961 ntf: Limit the logger buffer [#2961] Document with recorded changes attached. Activate "Show Changes" to see them [Edit/Track Changes/Show Changes] Thanks Canh _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
