Hi Vu,
Thanks for your suggest. I will update. Best Regards, ThienHuynh From: Nguyen Minh Vu <vu.m.ngu...@dektech.com.au> Sent: Thursday, January 16, 2020 5:11 PM To: thien.m.huynh <thien.m.hu...@dektech.com.au> Cc: opensaf-devel@lists.sourceforge.net Subject: Re: [PATCH 3/3] log: update README file for make facility id configurable [#3131] Hi Thien, Ack this patch with a comment. Regards, Vu On 1/16/20 11:08 AM, thien.m.huynh wrote: --- src/log/README | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/src/log/README b/src/log/README index 0d01e65d5..1d5469d6c 100644 --- a/src/log/README +++ b/src/log/README @@ -806,4 +806,21 @@ To test this feature, a GCC flag is added during compile time to simulate, SIMULATE_NFS_UNRESPONSE, the case the underlying file system is unresponsive, and it only takes effect when the cache size is given to a non-zero value. With that, the I/O thread will sleep *16 seconds* every 02 write requests. The flag -is disabled in default. \ No newline at end of file +is disabled in default. + + +5. Make facility ID configurable (#3131) +---------------------------------------------- +Streaming log record is packaged in RFC5424 format and they all carry a fixed +facility ID (16). Therefore, log record receiver i.e. rsyslogd is not able to +filter log records on their facility id such as which ones are regular logs +or which ones are security. + +The ticket to have the facility ID configurable so that the receiver can +differentiate among types of log records based on that number. + +Configure facility id via a new attribute `saLogStreamFacilityId` in class +`SaLogStreamConfig`. The valid range is [0-23]. The default value is 16 to keep +the streaming feature backward compatible. Always keep the value of attribute +`saLogStreamFacilityId` in sync with the standby. If user deletes value of the +attribute `saLogStreamFacilityId`, it will go back to the default value (16). [Vu] I would suggest to replace the two paragraphs above with this one: To address the limitation above, a new configurable attribute `saLogStreamFacilityId` is added to `SaLogStreamConfig` class; the attribute represents the facility of every streaming log record. It has 16 (local use 0) in default and a valid value is within the range [0 - 23]. When deleting the value of that attribute, it will go back to the default value (16). _______________________________________________ Opensaf-devel mailing list Opensaf-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensaf-devel
